OTOOLS-122: Add _runPendingActivations to ext-webpack-plugin for npm 12 compatibility - #298
Open
sencha-digit wants to merge 1 commit into
Open
OTOOLS-122: Add _runPendingActivations to ext-webpack-plugin for npm 12 compatibility#298sencha-digit wants to merge 1 commit into
sencha-digit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings
npm 12 dropped support for
installlifecycle scripts in published packages.@sencha/ext-*packages relied onscripts.install: "node activate.js"to activate the Ext JS license on first use. That hook is now silently skipped, leaving the package non-functional after install.Root cause
ext-webpack-pluginhad no mechanism to triggeractivate.jsonce the lifecycle script was removed.Fix
Added
_runPendingActivations()topluginUtil.js(bothsrc/and compileddist/), called at the top of_constructor()before the first webpack compilation.The function scans
node_modules/@sencha/*/activate.jsand runs each found script synchronously viaspawnSync.activate.jsself-deletes after running (existing behaviour), soexistsSyncmakes this a true one-shot check per install.Related PRs
extjs/SenchaDeploy#590 — removesscripts.installfrom published ext/cmd packages; convertsactivate.jstospawnSyncsencha/ext-gen— removesscripts.installfrom@sencha/ext-gen; lazyinstall.json first CLI invocation