Repository navigation
[AUT-14] Reconcile in_progress status with live leases/worktrees and export canonical executable queue (ticket-284) - #347
Conversation
…ecutable queue (ticket-284)
There was a problem hiding this comment.
Validator approval after policy checks for exact head 922254f49c1278ef82bcc1fdb0d5fda9206a8e72.
Ticket: ticket-284
Correlation ID: local-semcod-planfile-pr-347-ticket-284
Model: openai/cursor-auto
Reviewed diff chunks: 11
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 11 diff chunk(s). The visible change adds reconciliation and executable-queue APIs and CLI registration, and all protected required checks pass. However, the advertised top-level callable exports are exposed as module objects instead of functions. | The visible chunk introduces coherent typed contracts and candidate-evaluation foundations for the canonical executable queue. No code or security defect is evident in the reviewed section. | The visible chunk consistently centralizes executable-candidate evaluation, supplies canonical skip reasons, resolves dependencies and target repositories conservatively, excludes active or ambiguous lease bindings, and produces structured single-repository and fleet queue summaries. No unresolved correctness or security defect is evident in this chunk. | The visible chunk safely implements deterministic fleet queue aggregation and foundational repository reconciliation primitives, including bounded Git subprocess execution, normalized identifiers, target-branch discovery, and conservative filesystem/symlink handling. No unresolved correctness or security defect is evident in this chunk. | The visible repository-observation code handles missing, malformed, symlinked, expired, and terminal lease data conservatively; records active worktrees and unmerged ticket branches; parses terminal merge receipts without treating them as authoritative by themselves; and caches Git ancestry checks. No unresolved correctness or security defect is evident in this chunk. | The visible repository discovery, target resolution, ticket-binding extraction, and merge-evidence setup are coherent with the stated reconciliation behavior. Repository observations are cached, unobservable targets are preserved conservatively, and merge candidates require structured identifiers and valid Git SHA syntax before later ancestry verification. No unresolved code or security defect is evident in this chunk. | The visible reconciliation logic conservatively verifies merge evidence, preserves tickets with live leases or active worktrees, reports ambiguous observations, and uses optimistic concurrency for state transitions. No unresolved correctness or security defect is evident in this chunk. | The visible reconciliation implementation is coherent and safety-oriented: it preserves unobservable or ambiguous tickets, requires verified merge evidence before closing, retains tickets with live bindings, defaults to dry-run, and tracks CAS conflicts during applied transitions. Fleet aggregation consistently reuses observations and sums per-repository outcomes. No unresolved code or security defect is evident in this chunk. | The visible ticket metadata and executable-queue tests are coherent with the stated acceptance criteria. The tests cover ordering, dependency resolution across active and archived history, autonomy and execution-state exclusions, target-repository observability, active lease handling, archived-sprint exclusion, direct evaluator behavior, and schema reporting. No unresolved code or security defect is evident in this chunk. | The visible chunk adds focused coverage for repository-aware reconciliation and executable-queue behavior, including verified merge ancestry, rejection of unmerged terminal SHAs, live-lease retention, dirty-worktree retention, abandoned-ticket reopening, fleet ordering, and CLI/API parity. No unresolved code or security defect is evident in this chunk. | The visible test additions correctly exercise reopening abandoned tickets, preserving tickets whose target repositories cannot be observed, dry-run versus apply behavior for both CLI entry points, and fleet reconciliation reporting. No code or security defects are evident in this chunk.
Advisory findings: In planfile.__getattr__, requests for reconcile and executable_queue explicitly return their imported modules. Consequently, from planfile import reconcile and from planfile import executable_queue produce non-callable module objects, contradicting the public exports and PR claim that these functions are exported. Return the corresponding callable (while handling the submodule/package attribute collision) or remove the names from the advertised callable API.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 9e04c5b4d48e657038ff5320741dc8e66cd2abca...922254f49c1278ef82bcc1fdb0d5fda9206a8e72
Change digest: cf92ab3ff791cafc2d877ce8c6225de24703d386e481c43ac4bc3675ff34002d
Score: 64/100 (L), estimated 129 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":3193,"base_sha":"9e04c5b4d48e657038ff5320741dc8e66cd2abca","binary_files":0,"categories":{"code":7,"configuration":1,"docs":1,"tests":2},"change_digest":"cf92ab3ff791cafc2d877ce8c6225de24703d386e481c43ac4bc3675ff34002d","comparison":"9e04c5b4d48e657038ff5320741dc8e66cd2abca...922254f49c1278ef82bcc1fdb0d5fda9206a8e72","deletions":6,"file_count":11,"files":["planfile/__init__.py","planfile/cli/extra_commands.py","planfile/cli/groups/ticket/__init__.py","planfile/cli/groups/ticket/reconcile.py","planfile/contracts.py","planfile/executable_queue.py","planfile/reconcile.py","project/ticket-284/README.md","project/ticket-284/intent.json","tests/test_executable_queue.py","tests/test_reconcile_in_progress.py"],"head_sha":"922254f49c1278ef82bcc1fdb0d5fda9206a8e72","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":129,"within_budget":false},"impact":{"components":["git","leases","planfile","planfile.executable-queue","project","subactor","tests"],"files":["git/new-project/terminal-receipts.json","leases/worktrees","planfile.executable-queue/v1","planfile/__init__.py","planfile/cli/extra_commands.py","planfile/cli/groups/ticket/__init__.py","planfile/cli/groups/ticket/reconcile.py","planfile/contracts.py","planfile/executable_queue.py","planfile/reconcile.py","project/governance-check.sh","project/ticket-284/README.md","project/ticket-284/intent.json","subactor/leases","tests/test_executable_queue.py","tests/test_legacy_dependency_status.py","tests/test_reconcile_in_progress.py","tests/test_ticket_execution.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":17,"name":"Implement git","scope":["git"]},{"estimated_minutes":17,"name":"Implement leases","scope":["leases"]},{"estimated_minutes":17,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":17,"name":"Implement planfile.executable-queue","scope":["planfile.executable-queue"]},{"estimated_minutes":17,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-284"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-284: [AUT-14] Reconcile in_progress status with live leases/worktrees and export canonical executable queue (ticket-284)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 129m</text></svg>DECISION D-284-0526
TICKET ticket-284
HEAD_SHA 922254f49c1278ef82bcc1fdb0d5fda9206a8e72
CORRELATION_ID local-semcod-planfile-pr-347-ticket-284
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / remote lifecycle=PASS","governance / enforce=PASS","test (3.10)=PASS","freshness=PASS","test (3.13)=PASS","ci-loop=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":347,"head_sha":"922254f49c1278ef82bcc1fdb0d5fda9206a8e72","base_sha":"9e04c5b4d48e657038ff5320741dc8e66cd2abca","diff_sha256":"ea131ea6cacae5f26c9e49320d36e908ec980dbe62924c41d520c63155c6e90a"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/__init__.py","planfile/cli/extra_commands.py","planfile/cli/groups/ticket/__init__.py","planfile/cli/groups/ticket/reconcile.py","planfile/contracts.py","planfile/executable_queue.py","planfile/reconcile.py","project/ticket-284/README.md","project/ticket-284/intent.json","tests/test_executable_queue.py","tests/test_reconcile_in_progress.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"9e04c5b4d48e657038ff5320741dc8e66cd2abca","head_sha":"922254f49c1278ef82bcc1fdb0d5fda9206a8e72","change_digest":"cf92ab3ff791cafc2d877ce8c6225de24703d386e481c43ac4bc3675ff34002d","score":64,"complexity":"L","estimated_minutes":129,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Summary
Implements AUT-14 (Closes #346) under
ticket-284:in_progressreconciliation (planfile.reconcile,planfile reconcile,planfile ticket reconcile):.git/new-project/terminal-receipts.json(outcome == "merged"verified via Git ancestry on target branch) and landed merge commits, closing verified mergedin_progresstickets todonewith recordedterminalReceiptRefandterminalSha.in_progresswhen bound to a live non-expired.subactor/leases/*.jsonwriter lease, active worktree with uncommitted or ahead-of-target commits, or live Planfileexecution.lease_expires_at.in_progresstickets (no live lease and no active worktree) toopen(execution.state = "ready", clearing staleassigned_to/lease_expires_at/started_at) atomically under--apply(mutation_lock+expected_updated_atCAS), defaulting to dry-run reporting.unobservedwithout guessing or mutating.planfile.executable_queue,planfile.executable-queue/v1,planfile executable-queue,planfile ticket executable-queue):EXECUTABLE_QUEUE_SCHEMA(planfile.executable-queue/v1),is_executable_candidate,evaluate_executable_candidate,executable_skip_reason,executable_queue, andfleet_executable_queueshared across Planfile, Heyasa, andmonag.Validation
wellman run --root <worktree> --allow-primary-venv -- python -m pytest tests/test_reconcile_in_progress.py tests/test_executable_queue.py -v: 7 passed (plus 53 passed intests/test_ticket_execution.py&tests/test_legacy_dependency_status.py)ruff check&mypy --follow-imports=silent: 0 errors./project/governance-check.sh&wellman check:GOV-PASS