Skip to content

fix(sync): preserve managed GitHub descriptions and verify receipt readbacks - #345

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/283-preserve-managed-github-descriptions-across-round-trips
Nov 6, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/283-preserve-managed-github-descriptions-across-round-trips

Conversation

@tom-sapletta-com

@tom-sapletta-com tom-sapletta-com commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GitHub reads imported the entire issue body into the local description, so a later update could nest ownership markers and import independently written evidence. Read and replace only the unique managed description region, preserve all outside text, support explicit empty descriptions, and reject ambiguous or reserved markers before mutation. Legacy unmarked issue imports remain supported.

Verify the managed description on fresh and reused publication receipts, repair drift on the same issue, and fail mapped 404 updates without creating replacement issues. Existing repository identity, lifecycle, snapshot and active-execution guards remain enforced.

Closes #341. Native delivery: ticket-283; coordination: PLF-20372.

Validation: 808 GitHub/sync regression tests passed, including 42 focused description/receipt tests and the existing identity, raw-snapshot, SDK CAS and live-execution safeguards. Ruff and managed governance passed. Redirect test doubles now retain accepted description writes, and watch fixtures scope simulated time to the watch module so storage lock waits cannot consume poll ticks. Required OneDev and independent Validator checks run against the exact PR head.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head f56d116c6c91686fa6fcca0850abc8045a6a1fd7.

Ticket: ticket-283
Correlation ID: codex-heyasa-planfile283-description17-20261106
Model: openai/cursor-auto
Reviewed diff chunks: 3
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 3 diff chunk(s). The visible changes correctly introduce a uniquely bounded managed-description region, preserve independently authored issue-body content, support explicit empty descriptions, reject ambiguous or reserved markers before mutation, verify description readback, repair drift on the same mapped issue, and prevent unsafe replacement creation after a mapped 404. No unresolved code or security defect is evident in this chunk. | The visible chunk adds focused coverage for managed-description round trips, preservation of remote-only prose, explicit empty descriptions, legacy unmarked imports, ambiguous/reserved marker rejection before mutation, and idempotent create recovery. No unresolved code or security defect is evident in this chunk. | The visible changes add focused regression coverage for managed-description preservation, ambiguous marker rejection, receipt reuse and drift repair, mapped-issue identity retention, repository binding validation, SDK round trips, concurrency guards, redirect readback, and isolated watch timing. No unresolved code or security defect is evident in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 9abfd11f9d0c22c11ec2c5888d4c364682eb7885...f56d116c6c91686fa6fcca0850abc8045a6a1fd7
Change digest: f44020026fc38c70621489ad528552aecb3b9016a238f74e514446e1e6887f8e
Score: 72/100 (L), estimated 88 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":450,"base_sha":"9abfd11f9d0c22c11ec2c5888d4c364682eb7885","binary_files":0,"categories":{"code":3,"configuration":1,"docs":1,"tests":4},"change_digest":"f44020026fc38c70621489ad528552aecb3b9016a238f74e514446e1e6887f8e","comparison":"9abfd11f9d0c22c11ec2c5888d4c364682eb7885...f56d116c6c91686fa6fcca0850abc8045a6a1fd7","deletions":43,"file_count":9,"files":["planfile/sync/github.py","planfile/sync/operations.py","planfile/sync/outbound.py","project/ticket-283/README.md","project/ticket-283/intent.json","tests/test_github_description_roundtrip.py","tests/test_sync_legacy_operations.py","tests/test_sync_repository_redirects.py","tests/test_sync_watch_inbound_polling.py"],"head_sha":"f56d116c6c91686fa6fcca0850abc8045a6a1fd7","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":4,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":88,"within_budget":false},"impact":{"components":["GitHub","description","planfile","project","tests"],"files":["GitHub/sync","description/receipt","planfile/sync/github.py","planfile/sync/operations.py","planfile/sync/outbound.py","project/ticket-283/README.md","project/ticket-283/intent.json","tests/test_github_description_roundtrip.py","tests/test_sync_legacy_operations.py","tests/test_sync_repository_redirects.py","tests/test_sync_watch_inbound_polling.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":72,"split":{"parts":[{"estimated_minutes":16,"name":"Implement GitHub","scope":["GitHub"]},{"estimated_minutes":16,"name":"Implement description","scope":["description"]},{"estimated_minutes":16,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":16,"name":"Implement project","scope":["project"]},{"estimated_minutes":16,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-283"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-283: fix(sync): preserve managed GitHub descriptions and verify receipt readbacks</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 59,71 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 88m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-283-4726
TICKET ticket-283
HEAD_SHA f56d116c6c91686fa6fcca0850abc8045a6a1fd7
CORRELATION_ID codex-heyasa-planfile283-description17-20261106
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","test (3.13)=PASS","freshness=PASS","test (3.10)=PASS","governance / remote lifecycle=PASS","governance / enforce=PASS","ci-loop=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":345,"head_sha":"f56d116c6c91686fa6fcca0850abc8045a6a1fd7","base_sha":"9abfd11f9d0c22c11ec2c5888d4c364682eb7885","diff_sha256":"cea94aab5f498a6cbd9427fb4045fe7f0e0d4861bfafd3145b5ca3a33adaec2f"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/sync/github.py","planfile/sync/operations.py","planfile/sync/outbound.py","project/ticket-283/README.md","project/ticket-283/intent.json","tests/test_github_description_roundtrip.py","tests/test_sync_legacy_operations.py","tests/test_sync_repository_redirects.py","tests/test_sync_watch_inbound_polling.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"9abfd11f9d0c22c11ec2c5888d4c364682eb7885","head_sha":"f56d116c6c91686fa6fcca0850abc8045a6a1fd7","change_digest":"f44020026fc38c70621489ad528552aecb3b9016a238f74e514446e1e6887f8e","score":72,"complexity":"L","estimated_minutes":88,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 9e04c5b into main Nov 6, 2026
8 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/283-preserve-managed-github-descriptions-across-round-trips branch November 6, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve managed descriptions and planning through GitHub round trips

1 participant