Repository navigation
Preserve accepted ticket descriptions when blocking execution - #344
Conversation
There was a problem hiding this comment.
Validator approval after policy checks for exact head f6433a8519aa61282cea346725e53ac96e90aee1.
Ticket: ticket-282
Correlation ID: codex-heyasa-planfile282-fixture16-20261106
Model: openai/cursor-auto
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). The lifecycle change correctly preserves existing nonempty accepted descriptions while retaining the legacy synthetic blocker description for truly empty tickets. Block reasons remain recorded in history, and the existing execution-claim cleanup and note/output handling are preserved. The visible regression tests cover SDK, repeated, CLI, localized/whitespace, and legacy-empty-description cases. | The visible test assertions correctly verify preservation of the legacy blocked description presentation and recording of the blocker reason in history. No code or security defects are evident in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: db3b3ce50af2fe0df13e71158ce4625cd0f41001...f6433a8519aa61282cea346725e53ac96e90aee1
Change digest: d19644ef95637c40f3292676142b61531071a71f1a14c11674104d37d82e0c84
Score: 60/100 (L), estimated 67 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":194,"base_sha":"db3b3ce50af2fe0df13e71158ce4625cd0f41001","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"d19644ef95637c40f3292676142b61531071a71f1a14c11674104d37d82e0c84","comparison":"db3b3ce50af2fe0df13e71158ce4625cd0f41001...f6433a8519aa61282cea346725e53ac96e90aee1","deletions":3,"file_count":4,"files":["planfile/__init__.py","project/ticket-282/README.md","project/ticket-282/intent.json","tests/test_ticket_execution.py"],"head_sha":"f6433a8519aa61282cea346725e53ac96e90aee1","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":4,"scope":2,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":67,"within_budget":false},"impact":{"components":["DSL","planfile","project","sync","tests"],"files":["DSL/web","planfile/__init__.py","project/ticket-282/README.md","project/ticket-282/intent.json","sync/Goal","tests/test_ticket_execution.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":60,"split":{"parts":[{"estimated_minutes":12,"name":"Implement DSL","scope":["DSL"]},{"estimated_minutes":12,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":12,"name":"Implement project","scope":["project"]},{"estimated_minutes":12,"name":"Implement sync","scope":["sync"]},{"estimated_minutes":12,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-282"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-282: Preserve accepted ticket descriptions when blocking execution</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 105,51 79,85 59,71 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 67m</text></svg>DECISION D-282-4726
TICKET ticket-282
HEAD_SHA f6433a8519aa61282cea346725e53ac96e90aee1
CORRELATION_ID codex-heyasa-planfile282-fixture16-20261106
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","test (3.13)=PASS","test (3.10)=PASS","governance / enforce=PASS","ci-loop=PASS","freshness=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":344,"head_sha":"f6433a8519aa61282cea346725e53ac96e90aee1","base_sha":"db3b3ce50af2fe0df13e71158ce4625cd0f41001","diff_sha256":"4ca022f67a573ce70ad9393337ca7005f121784efc94653a626ae0fac7ef8426"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/__init__.py","project/ticket-282/README.md","project/ticket-282/intent.json","tests/test_ticket_execution.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"db3b3ce50af2fe0df13e71158ce4625cd0f41001","head_sha":"f6433a8519aa61282cea346725e53ac96e90aee1","change_digest":"d19644ef95637c40f3292676142b61531071a71f1a14c11674104d37d82e0c84","score":60,"complexity":"L","estimated_minutes":67,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"There was a problem hiding this comment.
Validator approval after policy checks for exact head f6433a8519aa61282cea346725e53ac96e90aee1.
Ticket: ticket-282
Correlation ID: local-semcod-planfile-pr-344-ticket-282
Model: openai/cursor-auto
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). The lifecycle change correctly preserves any existing accepted description while retaining the block reason in history, clearing the active execution claim, and preserving the established synthetic description behavior for truly empty legacy records. The added tests cover nonempty and repeated blocking, CLI behavior, execution cleanup, history, notes, inputs, results, and artifacts. No security defects are visible in this chunk. | The visible chunk adds assertions covering the intended legacy empty-description behavior: a blocked ticket retains the BLOCKED: reason presentation and records the reason in history. No unresolved code or security defect is evident in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: db3b3ce50af2fe0df13e71158ce4625cd0f41001...f6433a8519aa61282cea346725e53ac96e90aee1
Change digest: d19644ef95637c40f3292676142b61531071a71f1a14c11674104d37d82e0c84
Score: 60/100 (L), estimated 67 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":194,"base_sha":"db3b3ce50af2fe0df13e71158ce4625cd0f41001","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"d19644ef95637c40f3292676142b61531071a71f1a14c11674104d37d82e0c84","comparison":"db3b3ce50af2fe0df13e71158ce4625cd0f41001...f6433a8519aa61282cea346725e53ac96e90aee1","deletions":3,"file_count":4,"files":["planfile/__init__.py","project/ticket-282/README.md","project/ticket-282/intent.json","tests/test_ticket_execution.py"],"head_sha":"f6433a8519aa61282cea346725e53ac96e90aee1","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":4,"scope":2,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":67,"within_budget":false},"impact":{"components":["DSL","planfile","project","sync","tests"],"files":["DSL/web","planfile/__init__.py","project/ticket-282/README.md","project/ticket-282/intent.json","sync/Goal","tests/test_ticket_execution.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":60,"split":{"parts":[{"estimated_minutes":12,"name":"Implement DSL","scope":["DSL"]},{"estimated_minutes":12,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":12,"name":"Implement project","scope":["project"]},{"estimated_minutes":12,"name":"Implement sync","scope":["sync"]},{"estimated_minutes":12,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-282"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-282: Preserve accepted ticket descriptions when blocking execution</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 105,51 79,85 59,71 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 67m</text></svg>DECISION D-282-5778
TICKET ticket-282
HEAD_SHA f6433a8519aa61282cea346725e53ac96e90aee1
CORRELATION_ID local-semcod-planfile-pr-344-ticket-282
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","test (3.13)=PASS","test (3.10)=PASS","governance / enforce=PASS","ci-loop=PASS","freshness=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":344,"head_sha":"f6433a8519aa61282cea346725e53ac96e90aee1","base_sha":"db3b3ce50af2fe0df13e71158ce4625cd0f41001","diff_sha256":"4ca022f67a573ce70ad9393337ca7005f121784efc94653a626ae0fac7ef8426"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/__init__.py","project/ticket-282/README.md","project/ticket-282/intent.json","tests/test_ticket_execution.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"db3b3ce50af2fe0df13e71158ce4625cd0f41001","head_sha":"f6433a8519aa61282cea346725e53ac96e90aee1","change_digest":"d19644ef95637c40f3292676142b61531071a71f1a14c11674104d37d82e0c84","score":60,"complexity":"L","estimated_minutes":67,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Blocking a ticket currently replaces its accepted description with the blocker reason, losing scope and acceptance criteria. Preserve every nonempty description, retain reasons in history and explicit notes, and keep clearing the execution claim. Truly empty legacy descriptions retain their existing
BLOCKED: reasonpresentation.Fixes #340.
Validation: 40 lifecycle regressions and 66 existing DSL/web caller tests pass, plus Ruff and governance. Coverage includes repeated SDK and CLI blocking, full accepted snapshots with advisory text, and preservation of inputs, results, notes and artifacts. Protected publication must refresh this branch to the independently merged sync/Goal base and pass all eight required checks.