Skip to content

fix(sync): reconcile inbound state before guarded outbound publication - #342

Merged
ifuri-validator-agent[bot] merged 2 commits into
mainfrom
ticket/279-prevent-bidirectional-github-sync-from-reopening-stale-remote-closures
Nov 6, 2026
Merged

ifuri-validator-agent[bot] merged 2 commits into
mainfrom
ticket/279-prevent-bidirectional-github-sync-from-reopening-stale-remote-closures

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

GitHub bidirectional sync previously published a stale local snapshot before observing inbound closures, which could reopen a closed issue. It now reads inbound first, reloads the exact selected records and preserves local planning plus execution ownership.

Native outbound publishing uses detached payloads and exact raw snapshots. Backend references persist through the existing CAS API; concurrent owner plans, private notes and live execution survive even when a bulk writer keeps the same revision. Deferred lifecycle conflicts preserve successful other receipts, return failure and prevent false completion/comments. Explicit one-way, non-GitHub and legacy behavior retain coverage.

Validation: 128 native source tests passed (93 regressions/failure cases and 35 existing scope/repository controls), zero skips; native governance passed with zero errors/warnings; Ruff passed. Additional immutable-model diagnostics passed 128 tests. No gate disabled or required context waived. All changes use the existing three-file native279 scope; the old V1/V2 proposals were revised before application.

Source writer ownership was issued by the protected controller after the explicit bounded operator configuration decision; the exact candidate is publication-frozen at fencing838. This is editing/continuity evidence, not merge approval. Existing foreign ticket280 and its files are preserved.

Fixes #339. Related #341: the broader managed-body/API snapshot behavior remains separately tracked; this PR owns the bounded CLI orchestration guard only.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head ee37a21e0118e2fb3b33dc543abd514071af8615.

Ticket: ticket-279
Correlation ID: codex-heyasa-planfile279-20261106
Model: openai/cursor-auto
Reviewed diff chunks: 4
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 4 diff chunk(s). The visible chunk safely changes GitHub bidirectional synchronization to observe inbound lifecycle state before outbound mutation, preserves local planning fields, defers conflicting or unobserved lifecycle updates, and adds snapshot/CAS guards around outbound reference persistence. No unresolved code or security defect is evident in this chunk. | The visible change correctly prevents unresolved synchronization work from being reported as fully successful, preserves successful receipts, and retains the appropriate inbound pull path for directions that have not already pulled first. The ticket metadata and visible regression-test setup are consistent with the bounded bidirectional-sync fix. No code or security defects are evident in this chunk. | The visible chunk adds focused regression coverage for bidirectional sync ordering, lifecycle-conflict preservation, dry-run and one-way behavior, repository identity validation, CAS/concurrent-owner protections, and safe delivery of unaffected tickets. No unresolved code or security defect is evident in this chunk. | The visible regression tests correctly cover inbound reconciliation after partial outbound failure, deferred lifecycle conflicts, preservation of accepted local state, suppression of comments and false success reporting, and retention of successful receipts for unaffected tickets. No code or security defect is evident in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 14af092d7fac4e61b7c7a000029f5d7ebc9f8289...ee37a21e0118e2fb3b33dc543abd514071af8615
Change digest: 88110e95b997982908cc527891f0eed21ff5f5b12a0c3f3f2be92721d7cd0a17
Score: 68/100 (L), estimated 113 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":826,"base_sha":"14af092d7fac4e61b7c7a000029f5d7ebc9f8289","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":2},"change_digest":"88110e95b997982908cc527891f0eed21ff5f5b12a0c3f3f2be92721d7cd0a17","comparison":"14af092d7fac4e61b7c7a000029f5d7ebc9f8289...ee37a21e0118e2fb3b33dc543abd514071af8615","deletions":14,"file_count":6,"files":["planfile/cli/groups/sync/core.py","project/TICKETS.md","project/ticket-279/README.md","project/ticket-279/intent.json","tests/test_sync_bidirectional_order.py","tests/test_sync_failure_status.py"],"head_sha":"ee37a21e0118e2fb3b33dc543abd514071af8615","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":3,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":113,"within_budget":false},"impact":{"components":["V1","completion","editing","errors","managed-body","planfile","project","regressions","scope","tests"],"files":["V1/V2","completion/comments","editing/continuity","errors/warnings","managed-body/API","planfile/cli/groups/sync/core.py","project/TICKETS.md","project/ticket-279/README.md","project/ticket-279/intent.json","regressions/failure","scope/repository","tests/test_sync_bidirectional_order.py","tests/test_sync_failure_status.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":68,"split":{"parts":[{"estimated_minutes":11,"name":"Implement V1","scope":["V1"]},{"estimated_minutes":11,"name":"Implement completion","scope":["completion"]},{"estimated_minutes":11,"name":"Implement editing","scope":["editing"]},{"estimated_minutes":11,"name":"Implement errors","scope":["errors"]},{"estimated_minutes":11,"name":"Implement managed-body","scope":["managed-body"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-279"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-279: fix(sync): reconcile inbound state before guarded outbound publication</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 113m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-279-4726
TICKET ticket-279
HEAD_SHA ee37a21e0118e2fb3b33dc543abd514071af8615
CORRELATION_ID codex-heyasa-planfile279-20261106
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / enforce=PASS","test (3.13)=PASS","freshness=PASS","governance / remote lifecycle=PASS","test (3.10)=PASS","ci-loop=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":342,"head_sha":"ee37a21e0118e2fb3b33dc543abd514071af8615","base_sha":"14af092d7fac4e61b7c7a000029f5d7ebc9f8289","diff_sha256":"38862db6472d1daaaed8580ea1e52bf3dfa888b050893c18c036fc08ff279852"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/cli/groups/sync/core.py","project/TICKETS.md","project/ticket-279/README.md","project/ticket-279/intent.json","tests/test_sync_bidirectional_order.py","tests/test_sync_failure_status.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"14af092d7fac4e61b7c7a000029f5d7ebc9f8289","head_sha":"ee37a21e0118e2fb3b33dc543abd514071af8615","change_digest":"88110e95b997982908cc527891f0eed21ff5f5b12a0c3f3f2be92721d7cd0a17","score":68,"complexity":"L","estimated_minutes":113,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit db3b3ce into main Nov 6, 2026
8 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/279-prevent-bidirectional-github-sync-from-reopening-stale-remote-closures branch November 6, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent bidirectional GitHub sync from reopening remotely closed stale tickets

1 participant