Skip to content

ticket-277: update allocator highwater cache on ticket creation to prevent lock timeout on files > 5MB - #337

Merged
ifuri-validator-agent[bot] merged 3 commits into
mainfrom
ticket/277-update-allocator-highwater-cache-on-ticket-creation
Nov 3, 2026
Merged

ifuri-validator-agent[bot] merged 3 commits into
mainfrom
ticket/277-update-allocator-highwater-cache-on-ticket-creation

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Resolves PLF-23214.

  • Increase MAX_LOCKED_REBUILD_BYTES to 50MB in planfile/core/allocator_sprints.py.
  • Implement save_sprint_highwater and update_sprint_highwater_cache.
  • Synchronize allocator-sprints index cache upon ticket creation in _create_ticket_unlocked and _create_tickets_bulk_unlocked.
  • Add regression coverage in tests/test_allocator_preparation.py.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head ea70473a87d8ff4af130042d7904cbd2898dac3e.

Ticket: ticket-277
Correlation ID: local-semcod-planfile-pr-337-ticket-277
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 1 diff chunk(s). The cache write-through approach addresses the large-sprint rebuild problem, and all protected required checks passed, but the update path can promote invalid derived cache data into valid allocator evidence.
Advisory findings: update_sprint_highwater_cache trusts every JSON file matching source.name without validating its version, checksum, prior signature, canonical cache key, prefix type, or highest type. It then re-signs that untrusted/stale highest value with the current sprint signature via save_sprint_highwater. A corrupted or stale cache that sprint_highwater would normally reject can therefore become authoritative after any ticket write, causing incorrect high-water allocation (including large ID jumps and potentially unsafe evidence for ancillary prefixes). Validate cached entries with the same integrity rules used by sprint_highwater before preserving them; invalid or stale entries should be rebuilt from authoritative sprint records or discarded.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 808dc1d5c6cbfb114222c8de6153d1d5dade2d72...ea70473a87d8ff4af130042d7904cbd2898dac3e
Change digest: 295f69d215e1b0f5fdd8de2b5ec1f7e22fd7ed10541f01819e7db6b47fc3e1ac
Score: 44/100 (M), estimated 51 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":158,"base_sha":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72","binary_files":0,"categories":{"code":2,"configuration":1,"docs":2,"tests":1},"change_digest":"295f69d215e1b0f5fdd8de2b5ec1f7e22fd7ed10541f01819e7db6b47fc3e1ac","comparison":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72...ea70473a87d8ff4af130042d7904cbd2898dac3e","deletions":20,"file_count":6,"files":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-277/README.md","project/ticket-277/intent.json","tests/test_allocator_preparation.py"],"head_sha":"ea70473a87d8ff4af130042d7904cbd2898dac3e","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":51,"within_budget":false},"impact":{"components":["planfile","project","tests"],"files":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-277/README.md","project/ticket-277/intent.json","tests/test_allocator_preparation.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":14,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-277"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-277: ticket-277: update allocator highwater cache on ticket creation to prevent lock timeout on files &gt; 5MB</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 51m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-277-4546
TICKET ticket-277
HEAD_SHA ea70473a87d8ff4af130042d7904cbd2898dac3e
CORRELATION_ID local-semcod-planfile-pr-337-ticket-277
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / remote lifecycle=PASS","test (3.13)=PASS","freshness=PASS","test (3.10)=PASS","governance / enforce=PASS","ci-loop=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":337,"head_sha":"ea70473a87d8ff4af130042d7904cbd2898dac3e","base_sha":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72","diff_sha256":"8787fd4cd3da230cfba7987d82094e521d5156bd19436405dffbf4ec131b30d9"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-277/README.md","project/ticket-277/intent.json","tests/test_allocator_preparation.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72","head_sha":"ea70473a87d8ff4af130042d7904cbd2898dac3e","change_digest":"295f69d215e1b0f5fdd8de2b5ec1f7e22fd7ed10541f01819e7db6b47fc3e1ac","score":44,"complexity":"M","estimated_minutes":51,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head ea70473a87d8ff4af130042d7904cbd2898dac3e.

Ticket: ticket-277
Correlation ID: local-semcod-planfile-pr-337-ticket-277
Model: openai/gpt-6-luna
Reviewed diff chunks: 1
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 1 diff chunk(s). The required checks pass, but the cache update path can turn stale or corrupted allocator data into a cache entry trusted for the current sprint file.
Advisory findings: {'file': 'planfile/core/allocator_sprints.py', 'finding': "update_sprint_highwater_cache trusts each matching cache file's highest value without validating its version, checksum, or prior source signature, then saves that value with the new source signature and a fresh checksum. For example, if the sprint file has acquired a higher PLF ID but its cache is stale with a lower highwater, creating an unrelated-prefix ticket preserves the low PLF highwater and blesses it for the updated file. A later PLF allocation can then reuse an ID already present in the sprint. Validate the old cache against the pre-update source state or rebuild the highwater from the authoritative sprint contents before writing it with the new signature."}
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 808dc1d5c6cbfb114222c8de6153d1d5dade2d72...ea70473a87d8ff4af130042d7904cbd2898dac3e
Change digest: 295f69d215e1b0f5fdd8de2b5ec1f7e22fd7ed10541f01819e7db6b47fc3e1ac
Score: 44/100 (M), estimated 51 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":158,"base_sha":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72","binary_files":0,"categories":{"code":2,"configuration":1,"docs":2,"tests":1},"change_digest":"295f69d215e1b0f5fdd8de2b5ec1f7e22fd7ed10541f01819e7db6b47fc3e1ac","comparison":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72...ea70473a87d8ff4af130042d7904cbd2898dac3e","deletions":20,"file_count":6,"files":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-277/README.md","project/ticket-277/intent.json","tests/test_allocator_preparation.py"],"head_sha":"ea70473a87d8ff4af130042d7904cbd2898dac3e","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":51,"within_budget":false},"impact":{"components":["planfile","project","tests"],"files":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-277/README.md","project/ticket-277/intent.json","tests/test_allocator_preparation.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":14,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-277"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-277: ticket-277: update allocator highwater cache on ticket creation to prevent lock timeout on files &gt; 5MB</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 51m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-277-4482
TICKET ticket-277
HEAD_SHA ea70473a87d8ff4af130042d7904cbd2898dac3e
CORRELATION_ID local-semcod-planfile-pr-337-ticket-277
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / remote lifecycle=PASS","test (3.13)=PASS","freshness=PASS","test (3.10)=PASS","governance / enforce=PASS","ci-loop=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":337,"head_sha":"ea70473a87d8ff4af130042d7904cbd2898dac3e","base_sha":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72","diff_sha256":"8787fd4cd3da230cfba7987d82094e521d5156bd19436405dffbf4ec131b30d9"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-277/README.md","project/ticket-277/intent.json","tests/test_allocator_preparation.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"808dc1d5c6cbfb114222c8de6153d1d5dade2d72","head_sha":"ea70473a87d8ff4af130042d7904cbd2898dac3e","change_digest":"295f69d215e1b0f5fdd8de2b5ec1f7e22fd7ed10541f01819e7db6b47fc3e1ac","score":44,"complexity":"M","estimated_minutes":51,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/gpt-6-luna"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit a8f5179 into main Nov 3, 2026
8 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/277-update-allocator-highwater-cache-on-ticket-creation branch November 3, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant