Repository navigation
ticket-274: serve the last complete index to machine callers - #334
ifuri-validator-agent[bot] merged 2 commits into
Conversation
A full view has no durable fallback, so while the projection was being repaired it answered 503 - but only a browser user agent was allowed to read the last complete index, and only for 30 s. The same query therefore succeeded or failed depending on its client: measured 6 of 12 probes available on the deployed service. A full view now reuses its last complete answer for as long as a repairing projection would have been acceptable, marked X-Planfile-Index-State: stale, and require_fresh=true is never served a stale body.
…epair without bypassing fresh cache
There was a problem hiding this comment.
Validator approval after policy checks for exact head f43d680bac077133a59693f11443a1313ce7e668.
Ticket: ticket-274
Correlation ID: local-semcod-planfile-pr-334-ticket-274
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 1 diff chunk(s). The machine-caller stale fallback is reasonable, but the new freshness guarantee is incomplete for legacy unbounded requests.
Advisory findings: require_fresh=true does not override allow_index_stale. list_tickets still passes allow_index_stale=legacy_unbounded_request, and the contention path returns stale_index_response before reaching the new require_fresh 503 branch. Consequently, an unbounded legacy request with require_fresh=true can still receive the stale durable-index fallback, contrary to AC-02. Disable allow_index_stale when freshness is required or explicitly guard the stale-index return with not require_fresh, and add a test for this combination.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: ecf55530bfca8430c19e443f2cc14e5e12ae1716...f43d680bac077133a59693f11443a1313ce7e668
Change digest: 1f58d52686aeeab31a0c9798d593ae15be8ce170ab9b6bd9049d41c5e7a2bce7
Score: 56/100 (M), estimated 57 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":128,"base_sha":"ecf55530bfca8430c19e443f2cc14e5e12ae1716","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"1f58d52686aeeab31a0c9798d593ae15be8ce170ab9b6bd9049d41c5e7a2bce7","comparison":"ecf55530bfca8430c19e443f2cc14e5e12ae1716...f43d680bac077133a59693f11443a1313ce7e668","deletions":4,"file_count":5,"files":["planfile/api/server.py","project/TICKETS.md","project/ticket-274/README.md","project/ticket-274/intent.json","tests/test_sqlite_ticket_index.py"],"head_sha":"f43d680bac077133a59693f11443a1313ce7e668","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":3,"scope":2,"uncertainty":3,"validation":2},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":57,"within_budget":false},"impact":{"components":["planfile","project","tests"],"files":["planfile/api/server.py","project/TICKETS.md","project/governance-check.sh","project/ticket-274/README.md","project/ticket-274/intent.json","tests/test_sqlite_ticket_index.py"],"public_interfaces":["planfile/api/server.py"],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":56,"split":{"parts":[{"estimated_minutes":20,"name":"Define contract and acceptance boundary","scope":["planfile/api/server.py"]},{"estimated_minutes":10,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":10,"name":"Implement project","scope":["project"]},{"estimated_minutes":10,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-274"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-274: ticket-274: serve the last complete index to machine callers</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 54,78 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 57m</text></svg>DECISION D-274-3410
TICKET ticket-274
HEAD_SHA f43d680bac077133a59693f11443a1313ce7e668
CORRELATION_ID local-semcod-planfile-pr-334-ticket-274
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / remote lifecycle=PASS","governance / enforce=PASS","ci-loop=PASS","test (3.10)=PASS","test (3.13)=PASS","freshness=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":334,"head_sha":"f43d680bac077133a59693f11443a1313ce7e668","base_sha":"ecf55530bfca8430c19e443f2cc14e5e12ae1716","diff_sha256":"269b5b1306f565893de91cbb048041dba7e1c5ddc98cf92a4aaad016f95c30d5"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/api/server.py","project/TICKETS.md","project/ticket-274/README.md","project/ticket-274/intent.json","tests/test_sqlite_ticket_index.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"ecf55530bfca8430c19e443f2cc14e5e12ae1716","head_sha":"f43d680bac077133a59693f11443a1313ce7e668","change_digest":"1f58d52686aeeab31a0c9798d593ae15be8ce170ab9b6bd9049d41c5e7a2bce7","score":56,"complexity":"M","estimated_minutes":57,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Measured on the deployed service: the ticket API answered 6 of 12 probes twenty seconds apart:
Cause: a full view (
/tickets?sprint=current, the default) has no durable fallback, so while the projection was being repaired it answered503 ticket_index_repair_pending. Only a browser user agent was allowed to read the last complete index, and only inside a 30 s window — so the same query succeeded or failed depending on its client and on the moment.Change
_INDEX_REPAIR_STALE_WINDOW_SECONDS), marking itX-Planfile-Index-State: stale.require_fresh=truebypasses both the response cache and the stale projection; it waits (503) or answers from live sources, and never carries the stale marker.Verification
pytest tests/test_sqlite_ticket_index.py-> 75 passed, including the new test that warms a full view, invalidates the projection with an external edit, and checks both the stale answer and therequire_freshrefusal../project/governance-check.sh-> GOV-PASSPlanfile: PLF-22058.