Repository navigation
fix(autodiagnosis, ticket-138): report ExecCondition skips as AUTONOMY_UNIT_SKIPPED, not CRITICAL failures - #167
Conversation
…Y_UNIT_SKIPPED, not CRITICAL failures
There was a problem hiding this comment.
Validator approval after policy checks for exact head 2b27e743e257e355cc52ec02c3b3f05f1ccf264e.
Ticket: ticket-138
Correlation ID: local-semcod-monag-pr-167-ticket-138
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The change correctly distinguishes deliberate ExecCondition skips on inactive, non-failed units from actual unit failures, preserves critical reporting for failed states and other non-success results, and adds appropriate remediation guidance and focused regression coverage.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: ee1cff9d314fb80dcf0d2540abb4f49691a849f3...2b27e743e257e355cc52ec02c3b3f05f1ccf264e
Change digest: 8334252582fea95cf96297895f4b7290e6a6d41c3e81f2d8aab58f27f74ae388
Score: 48/100 (M), estimated 55 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":168,"base_sha":"ee1cff9d314fb80dcf0d2540abb4f49691a849f3","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"8334252582fea95cf96297895f4b7290e6a6d41c3e81f2d8aab58f27f74ae388","comparison":"ee1cff9d314fb80dcf0d2540abb4f49691a849f3...2b27e743e257e355cc52ec02c3b3f05f1ccf264e","deletions":2,"file_count":4,"files":["project/ticket-138/README.md","project/ticket-138/intent.json","src/monag/autodiagnosis.py","tests/test_autonomy_unit_skip.py"],"head_sha":"2b27e743e257e355cc52ec02c3b3f05f1ccf264e","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":55,"within_budget":false},"impact":{"components":["governance","project","src/monag","tests"],"files":["governance/governance_check.py","project/ticket-138/README.md","project/ticket-138/intent.json","src/monag/autodiagnosis.py","tests/test_autonomy_unit_skip.py","tests/test_wave2_mon01_mon04.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":12,"name":"Implement governance","scope":["governance"]},{"estimated_minutes":12,"name":"Implement project","scope":["project"]},{"estimated_minutes":12,"name":"Implement src/monag","scope":["src/monag"]},{"estimated_minutes":12,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-138"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-138: fix(autodiagnosis, ticket-138): report ExecCondition skips as AUTONOMY_UNIT_SKIPPED, not CRITICAL failures</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 55m</text></svg>DECISION D-138-8745
TICKET ticket-138
HEAD_SHA 2b27e743e257e355cc52ec02c3b3f05f1ccf264e
CORRELATION_ID local-semcod-monag-pr-167-ticket-138
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","governance / enforce=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","governance / remote lifecycle","governance / enforce"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/monag","pull_request":167,"head_sha":"2b27e743e257e355cc52ec02c3b3f05f1ccf264e","base_sha":"ee1cff9d314fb80dcf0d2540abb4f49691a849f3","diff_sha256":"0abc9acd8ea3add7ede01356673041110504da09dd3be954220974ca84f6e58f"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-138/README.md","project/ticket-138/intent.json","src/monag/autodiagnosis.py","tests/test_autonomy_unit_skip.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"ee1cff9d314fb80dcf0d2540abb4f49691a849f3","head_sha":"2b27e743e257e355cc52ec02c3b3f05f1ccf264e","change_digest":"8334252582fea95cf96297895f4b7290e6a6d41c3e81f2d8aab58f27f74ae388","score":48,"complexity":"M","estimated_minutes":55,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Summary
Follow-up refinement to
MON-01(#162, PR#166):_probe_systemd_user_unitsinsrc/monag/autodiagnosis.pysoResult=exec-conditionon aninactiveunit (SubState != "failed", e.g.subactor-repair-agent.serviceintentionally skipping cycles whenExecCondition=exits1..254/75) is reported asAUTONOMY_UNIT_SKIPPED(MEDIUM,weight: 700) with dedicated remediation guidance rather than aCRITICALAUTONOMY_UNIT_FAILED(weight: 1000).CRITICALAUTONOMY_UNIT_FAILEDforActiveState=failed,SubState=failed, and non-success inactive exit causes (exit-code,timeout,signal,start-limit-hit, etc.).tests/test_autonomy_unit_skip.py(unittest).Verification
python3 .governance/governance_check.py --actor ci --base ee1cff9d314fb80dcf0d2540abb4f49691a849f3 --head 2b27e743e257e355cc52ec02c3b3f05f1ccf264e->GOV-PASSpython -m unittest tests/test_autonomy_unit_skip.py tests/test_wave2_mon01_mon04.py->15 tests — OK