fix(ci): make tests portable across homes and distros - #2
Merged
Conversation
Statistics: 2 files changed, 31 insertions, 16 deletions Summary: - Dirs: tests=2 - Exts: .py=2 - A/M/D: 0/2/0 - Symbols: class TestChromeSafetyClassification, _home_path, class TestChromeCleanup Modified files: - tests/unit/test_service_cleanup.py (+12/-5) - tests/unit/test_service_scanner.py (+19/-11) Changes (notes): - tests/unit/test_service_cleanup.py (+12/-5): add functions: _home_path - tests/unit/test_service_scanner.py (+19/-11): add functions: _home_path Implementation notes (heuristics): - Type inferred from file paths + diff keywords + add/delete ratio - Scope prefers 'goal' when goal/* is touched; otherwise based on top-level dirs - For <=6 files: generate short per-file notes from added lines (defs/classes/click options/headings) - A/M/D derived from git name-status; per-file +X/-X from git numstat
stats: lines: "+5/-10 (net -5)" files: 1 complexity: "Stable complexity"
tom-sapletta-com
changed the title
![ifuri-validator-agent[bot]](https://avatars.githubusercontent.com/in/4344831?s=60&v=4){kind=small}
There was a problem hiding this comment.
Deterministic Validator approval for exact head 1440421905672a9874565d89d846dce1dc7d1ef2.
Ticket: ticket-001
Correlation ID: fixos-pr-2-ticket-001
Model: openrouter/z-ai/glm-5.2
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Test fixture paths are made portable by deriving home directories from pathlib.Path.home(), and the CI workflow switches to python3 -m pytest while removing redundant runtime pip installs. All reported checks pass and no security issues are present.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-001-8717
TICKET ticket-001
HEAD_SHA 1440421905672a9874565d89d846dce1dc7d1ef2
CORRELATION_ID fixos-pr-2-ticket-001
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test-summary=PASS","test-arch=PASS","test-debian=PASS","test-fedora=PASS","test-alpine=PASS","test-ubuntu=PASS","test (3.12)=PASS","test (3.10)=PASS","test (3.11)=PASS"]
INPUT required_checks = ["test (3.10)","test (3.11)","test (3.12)","test-summary"]
INPUT required_checks_source = "env/request"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openrouter/z-ai/glm-5.2"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for governance adoption PR #1.
The test fixtures previously embedded /home/tom while production expands the current user home. The Docker workflow also reinstalled test dependencies at runtime and invoked the non-portable
pythonalias.Changes:
pathlib.Path.home()python3 -m pytestin every distro containerpip install; each image already installs.[dev]Validation:
--network host; runs used--network noneDelivery head:
1440421905672a9874565d89d846dce1dc7d1ef2