Skip to content

fix(diagnostics, ticket-138): report partial removals and remove read-only trees - #181

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/138-truthful-partial-removal
Nov 16, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/138-truthful-partial-removal

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Problem

First live use of fixos anomalies --remove (2026-11-16) removed four of seven selected directories. The other three failed with EACCES and were reported as pominięto … (os_error:13), although shutil.rmtree had already deleted part of each (2.8, 2.6 and 1.1 GiB trees left at 1950, 478 and 656 MiB). One held 227 read-only directories owned by the user; two held 10 and 12 files owned by another account. The receipt therefore understated both what was deleted and what was freed.

Change

  • _remove_tree: on a failed entry owned by the current user, add the owner write bit to the entry and its parent and retry once (works with onexc on Python ≥ 3.12 and onerror before).
  • A tree that still exists after the attempt goes to a new partial list with reason, remaining_bytes and freed_bytes; it is in neither removed nor refused. freed_bytes in the receipt includes partially freed bytes, and a receipt is written for partial removals too.
  • The CLI prints częściowo: <path> (pozostało …, os_error:13).

No privilege escalation: entries owned by another user stay and are reported.

Verification

  • python -m pytest tests/unit/test_host_anomalies.py -q: 12 passed (2 new: read-only tree removed completely; unremovable entry reported as partial).
  • ruff check, ruff format --check: pass.
  • ./project/governance-check.sh: GOV-PASS.
  • Not run: the full test suite locally (CI runs it).

🤖 Generated with Claude Code

…-only trees

fixos anomalies --remove reported a tree as skipped after rmtree had
already deleted part of it. Make user-owned read-only entries writable and
retry once; list a tree that still exists under 'partial' with the reason
and remaining bytes, and count the bytes actually freed.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 2dbc5c6839926c820f783abab9f51562fb96068b.

Ticket: ticket-138
Correlation ID: local-semcod-fixos-pr-181-ticket-138
Model: openai/cursor-auto
Reviewed diff chunks: 2
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 2 diff chunk(s). Partial-removal accounting and classification are otherwise coherent, and all required checks passed, but the permission-retry implementation changes more permission bits than intended and can leave retained files with unsafe/unexpected modes. | The visible test assertions correctly verify that a partially removed tree retains a positive but reduced byte count, that total freed bytes include the partial removal, and that a receipt is written. No code or security defects are evident in this chunk.
Advisory findings: _remove_tree.retry applies stat.S_IRWXU to both the failed target and its parent. For a regular file whose unlink retry also fails, this adds owner read and execute permissions and then leaves that modified file in the partially removed tree. This contradicts the stated design of adding the owner write bit and unnecessarily turns data files executable. Adjust permissions according to entry type and operation—for example, grant only the minimum required directory permissions to the parent/affected directory, without adding execute permission to regular files.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 3cd0003ac81a7c455a37ccb63d610f85204099cd...2dbc5c6839926c820f783abab9f51562fb96068b
Change digest: cf595330c1f65aab7734f2738a3d9cea97b991fe1f27a0f98f6450777176ec49
Score: 52/100 (M), estimated 59 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":227,"base_sha":"3cd0003ac81a7c455a37ccb63d610f85204099cd","binary_files":0,"categories":{"code":2,"configuration":1,"docs":1,"tests":1},"change_digest":"cf595330c1f65aab7734f2738a3d9cea97b991fe1f27a0f98f6450777176ec49","comparison":"3cd0003ac81a7c455a37ccb63d610f85204099cd...2dbc5c6839926c820f783abab9f51562fb96068b","deletions":9,"file_count":5,"files":["fixos/cli/anomalies_cmd.py","fixos/diagnostics/host_anomalies.py","project/ticket-138/README.md","project/ticket-138/intent.json","tests/unit/test_host_anomalies.py"],"head_sha":"2dbc5c6839926c820f783abab9f51562fb96068b","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":59,"within_budget":false},"impact":{"components":["claude.com","fixos","project","tests"],"files":["claude.com/claude-code","fixos/cli/anomalies_cmd.py","fixos/diagnostics/host_anomalies.py","project/governance-check.sh","project/ticket-138/README.md","project/ticket-138/intent.json","tests/unit/test_host_anomalies.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":52,"split":{"parts":[{"estimated_minutes":13,"name":"Implement claude.com","scope":["claude.com"]},{"estimated_minutes":13,"name":"Implement fixos","scope":["fixos"]},{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-138"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-138: fix(diagnostics, ticket-138): report partial removals and remove read-only trees</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 59m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-138-7712
TICKET ticket-138
HEAD_SHA 2dbc5c6839926c820f783abab9f51562fb96068b
CORRELATION_ID local-semcod-fixos-pr-181-ticket-138
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test-summary=PASS","test (3.10)=PASS","test-arch=PASS","test (3.12)=PASS","governance / enforce=PASS","test (3.11)=PASS","governance / remote lifecycle=PASS","test-alpine=PASS","test-fedora=PASS","test-ubuntu=PASS","test-debian=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","test (3.10)","test (3.11)","test (3.12)","test-summary"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/fixos","pull_request":181,"head_sha":"2dbc5c6839926c820f783abab9f51562fb96068b","base_sha":"3cd0003ac81a7c455a37ccb63d610f85204099cd","diff_sha256":"376881f9ce70be1516c9e7920496b898e6f650cecd686834e579fcd20a87db9f"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["fixos/cli/anomalies_cmd.py","fixos/diagnostics/host_anomalies.py","project/ticket-138/README.md","project/ticket-138/intent.json","tests/unit/test_host_anomalies.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"3cd0003ac81a7c455a37ccb63d610f85204099cd","head_sha":"2dbc5c6839926c820f783abab9f51562fb96068b","change_digest":"cf595330c1f65aab7734f2738a3d9cea97b991fe1f27a0f98f6450777176ec49","score":52,"complexity":"M","estimated_minutes":59,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 63d6414 into main Nov 16, 2026
12 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/138-truthful-partial-removal branch November 16, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant