Repository navigation
Verify incremental analysis and cache identity (ticket-218) - #37
Conversation
Co-authored-by: Koru Agent <agent@coru.dev>
There was a problem hiding this comment.
Validator approval after policy checks for exact head 0a5340f2e47467b59b449f9e23f0d2cada95ba67.
Ticket: ticket-218
Correlation ID: local-semcod-code2llm-pr-37-ticket-218
Model: openai/cursor-auto
Reviewed diff chunks: 4
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 4 diff chunk(s). The visible chunk correctly adds exact single-file analysis, a conservative incremental API with content verification and drift detection, cache identity propagation, and aligned export-cache context. No unresolved code or security defect is evident in this chunk. | The visible cache changes correctly replace metadata-only reuse with source-byte verification, namespace persistent results by a validated analysis identity, propagate the complete configuration to parallel workers, and track deleted files. No unresolved code or security defect is evident in this chunk. | The visible changes consistently add installed-distribution coverage for incremental cache reuse, metadata-preserving source rewrites, uncached equivalence, and single-file isolation; update cache tests to use configuration-bound identities; aggregate cache namespace summaries; and advance the package version. No unresolved code or security defect is evident in this chunk. | The visible chunk adds strong regression coverage for cache invalidation, advisory change hints, drift detection, cache safety, graph relinking, parallel configuration propagation, export-cache namespacing, and namespace garbage collection. The version lock update is consistent with the stated release version. No code or security defect is evident in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: c055d4e1c6f83024b2cfc88e250b42c4e4abf64d...0a5340f2e47467b59b449f9e23f0d2cada95ba67
Change digest: 9522b4dfea224ab5eb40c9af0ea58f15cb9888b123a5d6f47a7c083e436603a9
Score: 80/100 (L), estimated 183 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":505,"base_sha":"c055d4e1c6f83024b2cfc88e250b42c4e4abf64d","binary_files":0,"categories":{"code":11,"configuration":1,"tests":3},"change_digest":"9522b4dfea224ab5eb40c9af0ea58f15cb9888b123a5d6f47a7c083e436603a9","comparison":"c055d4e1c6f83024b2cfc88e250b42c4e4abf64d...0a5340f2e47467b59b449f9e23f0d2cada95ba67","deletions":86,"file_count":15,"files":["VERSION","code2llm/__init__.py","code2llm/api.py","code2llm/cli_exports/orchestrator.py","code2llm/core/analyzer.py","code2llm/core/config.py","code2llm/core/file_cache.py","code2llm/core/persistent_cache.py","pyproject.toml","scripts/verify_projection_distribution.py","setup.py","tests/test_cache_invalidation_e2e.py","tests/test_declarative_collection.py","tests/test_incremental_api.py","uv.lock"],"head_sha":"0a5340f2e47467b59b449f9e23f0d2cada95ba67","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":5,"scope":5,"uncertainty":3,"validation":2},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":183,"within_budget":false},"impact":{"components":["3.10","Before","code2llm","content","edit","inventory","lookup","parser","per-file","planfile","repository-root","scripts","source","tests","wheel"],"files":["3.10/3.13","Before/after","VERSION","code2llm/__init__.py","code2llm/api.py","code2llm/cli_exports/orchestrator.py","code2llm/core/analyzer.py","code2llm/core/config.py","code2llm/core/file_cache.py","code2llm/core/persistent_cache.py","content/off","edit/touch/rename/delete","inventory/GC","lookup/save","parser/native","per-file/persistent","planfile/evidence/forge-dependencies-20261112/dep002-source-checkpoint.json","pyproject.toml","scripts/verify_projection_distribution.py","setup.py","source/config/runtime","tests/test_cache_invalidation_e2e.py","tests/test_declarative_collection.py","tests/test_incremental_api.py","uv.lock","wheel/sdist"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":80,"split":{"parts":[{"estimated_minutes":12,"name":"Implement 3.10","scope":["3.10"]},{"estimated_minutes":12,"name":"Implement Before","scope":["Before"]},{"estimated_minutes":12,"name":"Implement code2llm","scope":["code2llm"]},{"estimated_minutes":12,"name":"Implement content","scope":["content"]},{"estimated_minutes":12,"name":"Implement edit","scope":["edit"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-218"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-218: Verify incremental analysis and cache identity (ticket-218)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 54,78 23,51" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 183m</text></svg>DECISION D-218-3739
TICKET ticket-218
HEAD_SHA 0a5340f2e47467b59b449f9e23f0d2cada95ba67
CORRELATION_ID local-semcod-code2llm-pr-37-ticket-218
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["freshness=FAIL","test (3.13)=PASS","test (3.10)=PASS"]
INPUT required_checks = ["test (3.10)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/code2llm","pull_request":37,"head_sha":"0a5340f2e47467b59b449f9e23f0d2cada95ba67","base_sha":"c055d4e1c6f83024b2cfc88e250b42c4e4abf64d","diff_sha256":"9c6841bb37c96b2557939e30e85c046b4fa0f52ec8938c4fd86fe89a34e912cf"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["VERSION","code2llm/__init__.py","code2llm/api.py","code2llm/cli_exports/orchestrator.py","code2llm/core/analyzer.py","code2llm/core/config.py","code2llm/core/file_cache.py","code2llm/core/persistent_cache.py","pyproject.toml","scripts/verify_projection_distribution.py","setup.py","tests/test_cache_invalidation_e2e.py","tests/test_declarative_collection.py","tests/test_incremental_api.py","uv.lock"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"c055d4e1c6f83024b2cfc88e250b42c4e4abf64d","head_sha":"0a5340f2e47467b59b449f9e23f0d2cada95ba67","change_digest":"9522b4dfea224ab5eb40c9af0ea58f15cb9888b123a5d6f47a7c083e436603a9","score":80,"complexity":"L","estimated_minutes":183,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
A rewrite preserving mtime and size returned stale function names from the public analyzer, and analyze_file silently scanned sibling files. Verify source bytes before cache reuse, bind per-file/persistent analysis to the full configuration and parser/native backend identity, and analyze exactly the requested file.
Expose analyze_incremental with an explicit private cache directory, content/off policy, versioned source/config/runtime identity, conservative full graph relinking and phase timings. Changed-file hints are advisory. Before/after inventories reject observed drift and explicitly report snapshot_atomic=false; immutable execution snapshots remain Forge DEP-011. Forward the complete configuration to parallel workers. Keep CLI export lookup/save and cache inventory/GC aligned with the new configuration namespaces.
Version 0.5.186 joins this implementation. The existing release distribution checker now exercises the installed public API, real cache reuse, a metadata-preserving rewrite, uncached comparison and single-file scope in both wheel and sdist.
Validation: all 404 tests pass on Python 3.10. Regressions cover edit/touch/rename/delete, equal bytes with distinct source identities, configuration changes, cycles, omitted change hints, parallel configuration, private cache policy, drift, export invalidation and namespace GC. Fresh wheel/sdist installations pass on Python 3.13; 177 packaged Python modules match the reviewed source bytes. A local portable-Python-3.10 nested venv failed before artifact installation; the required hosted 3.10/3.13 matrix and its installed-distribution checks remain mandatory. Further installed-runtime qualification is in progress. No release or Forge pin change is claimed before independent merge and actual publication.
Native source ticket: code2llm:PLF-218 (distinct store from paxlet-com:PLF-22344). Evidence: paxlet-com:.planfile/evidence/forge-dependencies-20261112/dep002-source-checkpoint.json and dep002-distribution-binding.json. Publication must use the independent Validator against this exact head.