Skip to content

fix: stabilize discovery ticket identities and refresh internal lock - #32

Merged
ifuri-validator-agent[bot] merged 3 commits into
mainfrom
dependabot/uv/internal-packages-bcafd2ff48
Oct 22, 2026
Merged

ifuri-validator-agent[bot] merged 3 commits into
mainfrom
dependabot/uv/internal-packages-bcafd2ff48

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Identical data-clump findings previously generated different ticket names and deduplication keys after process restarts because frozenset iteration depends on PYTHONHASHSEED. Sort the emitted argument and related-function lists so the same source produces stable names, descriptions, context and exported ticket identities (PLF-214). Per-file grouping and detection thresholds remain intact.

Repair two pre-existing prompt-engine test doubles to accept the current keyword-only max_lines call while preserving all token-budget and metric assertions (PLF-215). Keep the grouped internal dependency updates and refresh the stale Goal lock from 2.2.0 to 2.2.1.

Validation: the new real subprocess regression fails against the previous detector and passes across seeds 1, 2 and 42, including reversed argument and function discovery order. All 368 tests pass on each locked Python 3.10 and 3.13 environment using the native -n2 matrix command. The primary-registry catalog freshness audit passes. Existing required checks and independent protected Validator publication remain in force.

Bumps the internal-packages group with 3 updates: costs, [clickmd](https://github.com/wronai/clickmd) and [pfix](https://github.com/softreck/pfix).


Updates `costs` from 0.2.0 to 0.2.1

Updates `clickmd` from 1.1.15 to 1.1.16
- [Changelog](https://github.com/semcod/clickmd/blob/main/CHANGELOG.md)
- [Commits](semcod/clickmd@v1.1.15...v1.1.16)

Updates `pfix` from 0.1.79 to 0.1.80
- [Commits](https://github.com/softreck/pfix/commits)

---
updated-dependencies:
- dependency-name: costs
  dependency-version: 0.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: internal-packages
- dependency-name: clickmd
  dependency-version: 1.1.16
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: internal-packages
- dependency-name: pfix
  dependency-version: 0.1.80
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: internal-packages
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code labels Oct 22, 2026
tom-sapletta-com and others added 2 commits October 23, 2026 00:41
…214)

Co-authored-by: Koru Agent <agent@coru.dev>
Co-authored-by: Koru Agent <agent@coru.dev>
@tom-sapletta-com tom-sapletta-com changed the title deps: bump the internal-packages group with 3 updates fix: stabilize discovery ticket identities and refresh internal lock Oct 22, 2026

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 28ca36385e96f04fd1d9779669269e031f3d45af.

Ticket: PLF-215
Correlation ID: local-semcod-code2llm-pr-32-PLF-215
Model: openai/cursor-auto
Reviewed diff chunks: 4
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 4 diff chunk(s). The visible code makes data-clump output deterministic by sorting argument and function collections before constructing names, descriptions, context, and exported identities. The subprocess regression appropriately varies hash seeds and discovery order, and the prompt-engine test doubles now match the keyword-only max_lines interface. Both protected required checks passed. | The visible lockfile updates are internally consistent with the stated dependency refresh, and no code or security defects are evident in this chunk. Both protected required checks passed. | The visible chunk is a generated uv.lock refresh, including pfix 0.1.80 and marker normalization consistent with package-level resolution constraints. No independently evidenced code or security defect is visible. Both protected required checks passed. | The visible lockfile change removes a Python-version marker from the yarg dependency on requests. No correctness or security defect is evident in this chunk, and all protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: f0260dfff78e33a0f8ac3fca36795b6d927b528e...28ca36385e96f04fd1d9779669269e031f3d45af
Change digest: bf291f97febfcad19d1e045b60a0afeb1b0297fe1859f66e03d3099dbe5c264e
Score: 52/100 (M), estimated 56 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":188,"base_sha":"f0260dfff78e33a0f8ac3fca36795b6d927b528e","binary_files":0,"categories":{"code":2,"tests":2},"change_digest":"bf291f97febfcad19d1e045b60a0afeb1b0297fe1859f66e03d3099dbe5c264e","comparison":"f0260dfff78e33a0f8ac3fca36795b6d927b528e...28ca36385e96f04fd1d9779669269e031f3d45af","deletions":131,"file_count":4,"files":["code2llm/analysis/smell_engine.py","tests/test_prompt_engine.py","tests/test_smells_data_clumps.py","uv.lock"],"head_sha":"28ca36385e96f04fd1d9779669269e031f3d45af","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":3,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":56,"within_budget":false},"impact":{"components":["code2llm","repository-root","tests"],"files":["code2llm/analysis/smell_engine.py","tests/test_prompt_engine.py","tests/test_smells_data_clumps.py","uv.lock"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":52,"split":{"parts":[{"estimated_minutes":16,"name":"Implement code2llm","scope":["code2llm"]},{"estimated_minutes":16,"name":"Implement repository-root","scope":["repository-root"]},{"estimated_minutes":16,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"PLF-215"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>PLF-215: fix: stabilize discovery ticket identities and refresh internal lock</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 89,56 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 56m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-215-6560
TICKET PLF-215
HEAD_SHA 28ca36385e96f04fd1d9779669269e031f3d45af
CORRELATION_ID local-semcod-code2llm-pr-32-PLF-215
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "dependabot[bot]"
INPUT observed_checks = ["test (3.10)=PASS","freshness=PASS","test (3.13)=PASS"]
INPUT required_checks = ["test (3.10)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/code2llm","pull_request":32,"head_sha":"28ca36385e96f04fd1d9779669269e031f3d45af","base_sha":"f0260dfff78e33a0f8ac3fca36795b6d927b528e","diff_sha256":"312e040af39fb7e458f6fa084138d5537d62e6783d643a510c091c8a8f33a008"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["code2llm/analysis/smell_engine.py","tests/test_prompt_engine.py","tests/test_smells_data_clumps.py","uv.lock"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"f0260dfff78e33a0f8ac3fca36795b6d927b528e","head_sha":"28ca36385e96f04fd1d9779669269e031f3d45af","change_digest":"bf291f97febfcad19d1e045b60a0afeb1b0297fe1859f66e03d3099dbe5c264e","score":52,"complexity":"M","estimated_minutes":56,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit e1da49e into main Oct 22, 2026
3 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the dependabot/uv/internal-packages-bcafd2ff48 branch October 22, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant