Repository navigation
Conversation
Contributor
|
Thanks, Aditya, this is a clean piece of work. I checked out the branch and ran the full suite: 642 run, 0 failures, matching your numbers. Review notes:
Two things before it can merge:
I found nothing blocking in the code itself. Thanks for picking this one up! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
Summary
isFocused()andisEmpty()assertionsPatternoverloads for full text/value matching and partial text matchingValidation
mvn -q -Dtest=LocatorAssertBehaviorTest,SeleniumAssertTest test(11 passed)mvn -q test(642 passed, 0 failed/error/skipped)mvn -q verifycompleted compilation and all tests, then stopped at the release-only GPG signing goal because GPG is not installed on this hostgit diff --checkNo browser-backed sample was needed: the focused tests exercise WebDriver polling, focus ownership, form emptiness, regex semantics, stale-element re-resolution, and failure diagnostics directly.