Repository navigation
feat(locator): press, focus, doubleClick, rightClick #134
Description
BasePage has doubleClick / rightClick and Locator has hover, but Locator has no doubleClick(), rightClick(), focus() or press(Keys...) (e.g. getByLabel("Search").press(Keys.ENTER)). Add them so the Locator API is the one place to look.
Acceptance: tests pass (unit tests under src/test, plus a case against a real page in the sample project if it needs a browser); Javadoc on each public method; a changelog entry in docs-site/docs/changelog.md; one line in the locators guide. Terminal actions must follow the existing contract: resolve from scratch on every poll and retry stale/not-yet-present elements until timeouts.explicit (see #67/#68). See CONTRIBUTING.md; comment to claim it.
Activity
TONGdamy commentedon Oct 13, 2026
Hi, I’d be happy to contribute to this issue if it is still available. I plan to add the four Locator methods, following the existing auto-waiting and stale-element retry behaviour, together with tests, Javadoc, and the required documentation updates.
Would it be possible to assign this issue to me? Thank you for your time and consideration!
shossain786 commentedon Oct 14, 2026
Hi @TONGdamy, welcome, and thanks for offering. It's yours; I've assigned it to you.
A few pointers so the first review goes smoothly:
timeouts.explicit(spike(locator): stale-proof click() — re-resolve on every poll #67/feat(locator): terminal actions wait for presence and re-resolve on every poll #68).click()andhover()inLocator.javaare the reference.docs-site/docs/changelog.mdand the locators guide, so expect a small rebase on those two files.TONGdamy commentedon Oct 14, 2026
Hi @shossain786, thank you for assigning this issue to me and for the helpful guidance!
Would it be alright for my teammate @crystalmountain666 and me to work on this together? If so, could you please add them as a second assignee alongside me?
We plan to submit one joint PR covering the implementation, tests, and documentation. Thank you for your time!
shossain786 commentedon Oct 14, 2026
Yes, working together on one joint PR is fine, @TONGdamy. GitHub only lets me assign people who have already taken part in the repo, so I couldn't add @crystalmountain666 as a second assignee. If they comment here once, I'll add them. In the meantime, add them to the commits with a
Co-authored-by:trailer so they get credit in the history. One PR, one set of tests, docs and changelog, as you planned.crystalmountain666 commentedon Oct 14, 2026
Hi! Thanks for explaining! I'm a teammate of @TONGdamy. I left a comment here so you can add me as a second assignee. We'll work together on the same PR as planned. Thank you for your help!！
shossain786 commentedon Oct 14, 2026
Thanks @crystalmountain666, you're added as a second assignee. Over to you both. Open a draft PR early if you'd like a design check.