refactor(node): read Reconcile as a step list; extract hold predicates

[bdchatham]

Behavior-preserving readability refactor of SeiNodeReconciler.Reconcile — it now reads as a sequence of named steps rather than prose-annotated orchestration.

What changed (structure + comment placement only)

• Extracted the two inline hold predicates into named methods, relocating their rationale to the methods' doc comments:
  • holdInitialSTS RHS → shouldHoldInitialStatefulSet(node) (statefulset.go, next to reconcileStatefulSet)
  • holdForWorkflow RHS → adoptedWorkflowIsExecuting(node) (workflow.go, next to adoptedWorkflowParkedFailed)
• Kept the StateSyncReady-ordering invariant at its call site (trimmed 7→4 lines) — it's a sequencing dependency not visible from call order.
• Deliberately left inline (documented): the status-snapshot bundle (extracting it would thread a struct through reconcileWorkflow's existing signature for zero gain) and the two flush-and-return exits (distinct error-wrap strings a shared helper would blur).

Behavior

No control-flow change. The if !holdInitialSTS && !holdForWorkflow guard is byte-identical (the locals are kept as the readable step names). Existing internal/controller/node + internal/planner tests pass unchanged — the behavior-preservation proof. gofmt/vet/build clean.

🤖 Generated with Claude Code

[cursor]

PR Summary

Low Risk
No logic changes—only comment relocation and predicate extraction; the STS apply guard is byte-identical.

Overview
Readability-only refactor of SeiNodeReconciler.Reconcile: the two StatefulSet skip conditions are now named steps instead of long inline comments.

holdInitialSTS and holdForWorkflow still gate reconcileStatefulSet the same way (if !holdInitialSTS && !holdForWorkflow), but their logic lives in shouldHoldInitialStatefulSet (statefulset.go, next to reconcileStatefulSet) and adoptedWorkflowIsExecuting (workflow.go, beside adoptedWorkflowParkedFailed). The prior rationale (state-sync gate vs data PVC, mid-wipe workflow vs parked-failed release) moves into those functions’ doc comments.

The StateSyncReady ordering note at the gate call site is shortened; no sequencing or control-flow change.

^{Reviewed by Cursor Bugbot for commit 3d34a68. Bugbot is set up for automated code reviews on this repo. Configure here.}