test(integration): TestNightly<Suite> convention + no-match guard for the consolidated nightly

[bdchatham]

Summary

Prepares the integration harness for the platform-side consolidation of the 5 per-suite nightly CronJobs into one. Test-only; no controller/CRD/SDK change.

1. Per-suite image env vars — running every suite in one process means one environment, so the three suites that can't use the shared SEID_IMAGE default read their own: SEID_IMAGE_MOCK (benchmark), SEID_IMAGE_CHAOS (chaos), SEID_UPGRADE_FROM_IMAGE/SEID_UPGRADE_TO_IMAGE (upgrade's pinned pre/post pair). Release/workflow/giga/giga-mixed keep the shared SEID_IMAGE.
2. TestNightly<Suite> naming convention — all 7 nightly suites renamed so -test.run '^TestNightly' selects the whole set by convention; a new suite joins by taking the prefix, no allowlist to maintain. TestGenesisCeremonyProducesBlocks stays outside the prefix (onboarding check, run standalone).
3. No-match-fails-loud guard — go test exits 0 when -test.run matches nothing; against a live cluster that means the harness binary and the pattern are out of sync (an image built before a rename) — a false-healthy nightly that ran nothing. TestMain now fails the run when zero suites started against a cluster. Counts executed suites at requireCluster (the universal entry point), so no per-suite wiring.
4. Reused-code refactor — witnessNamespace + assertWitnessFresh extracted to harness_test.go; the namespace-derivation and witness-freshness gate were duplicated verbatim between the state-sync and giga-mixed suites (a must-change-together correctness coupling).

Companion / sequencing

The platform PR (sei-protocol/platform#feat/nightly-cron-consolidation) collapses the 5 CronJobs into one nightly-harness-suite running -test.run '^TestNightly'. Merge order matters: this PR must land first so its ECR push-build produces a harness image carrying the TestNightly* names; the platform CronJob then pins that image atomically. The no-match guard is the backstop if that ordering ever slips.

Deliberately not included (recorded in the review ledger): per-suite panic recovery — the completion SLI (count of --- PASS/FAIL: TestNightly == 7, an observability follow-up) is the robust layer for detecting a dropped suite, not scattered recovers.

Review

xreview ledger: bdchatham-designs/designs/seinode-task/xreview/workflow-complete-at-release.md rounds 20-22. Four-lens cross-repo review (kubernetes-specialist, platform-engineer, sre-engineer as assigned dissenter, idiomatic-reviewer) + a systems-engineer raise-the-bar pass + a verify round on the guard/refactor (systems + idiom, both RATIFY). Gates: gofmt, go vet -tags integration, go test -c -tags integration, -test.run '^TestNightly' selection all clean.

🤖 Generated with Claude Code

[cursor]

PR Summary

Low Risk
Test-only integration harness and Dockerfile comments; no controller, SDK, or production runtime changes. Operational risk is mainly merge ordering with the platform CronJob consolidation.

Overview
Prepares the integration harness for one nightly CronJob running -test.run '^TestNightly' instead of per-suite jobs. The Dockerfile and package docs now describe that single-binary, whole-set invocation.

Naming: Seven scheduled suites are renamed to TestNightly<Suite> so the regex selects them by convention; TestGenesisCeremonyProducesBlocks stays outside the prefix for standalone onboarding runs.

One process, multiple images: Benchmark, chaos, and upgrade suites read dedicated env vars (SEID_IMAGE_MOCK, SEID_IMAGE_CHAOS, SEID_UPGRADE_FROM_IMAGE / SEID_UPGRADE_TO_IMAGE) because a combined run shares one environment; release/workflow/giga suites keep SEID_IMAGE.

Safety: TestMain fails exit 0 when SEI_NODE_CLUSTER is set but requireCluster never incremented suitesStarted—catching a -test.run pattern that matches nothing after a rename or image skew.

Refactor: witnessNamespace and assertWitnessFresh move to harness_test.go and replace duplicated logic in state-sync and giga-mixed suites.

^{Reviewed by Cursor Bugbot for commit 8d68711. Bugbot is set up for automated code reviews on this repo. Configure here.}