ci(ecr): build the combined mock_chain_validation-mock_balances flavor per ref#3756
ci(ecr): build the combined mock_chain_validation-mock_balances flavor per ref#3756bdchatham wants to merge 1 commit into
Conversation
…r per ref The chaos suite's flavor was producible only by the nightly pipeline from main HEAD; a workflow_dispatch for an arbitrary ref could cover every other harness suite but not chaos. Mirrors the nightly step with ecr.yml's shared cache and tag scheme. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
An organization admin can view or raise the cap at claude.ai/admin-settings/claude-code. The cap resets at the start of the next billing period.
Once the cap resets or is raised, push a new commit or reopen this pull request to trigger a review.
PR SummaryLow Risk Overview The new step sits alongside the existing single-tag mock variants and uses the same shared registry build cache and ref-based tag pattern ( Reviewed by Cursor Bugbot for commit dd93779. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
Adds a fifth ECR build step that produces the combined mock_chain_validation-mock_balances seid flavor for an arbitrary ref, mirroring the existing mock-flavor steps exactly. The change is correct, consistent, and safe to merge.
Findings: 0 blocking | 2 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The Cursor second-opinion review file (cursor-review.md) was empty — that pass produced no output. Codex reported no material issues, and REVIEW_GUIDELINES.md was empty.
- Verified against the Dockerfile:
GO_BUILD_TAGSis expanded intoBUILD_TAGS="netgo ledger ${GO_BUILD_TAGS}", so the space-separatedmock_balances mock_chain_validationvalue correctly resolves to two build tags. The new step's cache, platform, and tag-fallback settings match the surrounding steps.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3756 +/- ##
==========================================
- Coverage 59.93% 59.02% -0.92%
==========================================
Files 2288 2201 -87
Lines 189868 180025 -9843
==========================================
- Hits 113793 106255 -7538
+ Misses 65942 64438 -1504
+ Partials 10133 9332 -801
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The chaos harness suite consumes the combined
mock_chain_validation-mock_balancesseid flavor, which today is producible only by the nightly pipeline frommainHEAD. Aworkflow_dispatchofecr.ymlfor an arbitrary ref (the mechanism for validating a PR head against the harbor nightly harness) covers every other suite's flavor but not chaos.Adds a fifth build step mirroring the nightly pipeline's combined-flavor step, using ecr.yml's shared build cache and tag scheme (
mock_chain_validation-mock_balances-<ref>). Found while wiring full-harness validation of #3753 against its true head.🤖 Generated with Claude Code