Skip to content

ci(ecr): build the combined mock_chain_validation-mock_balances flavor per ref#3756

Open
bdchatham wants to merge 1 commit into
mainfrom
ci/ecr-combined-mock-flavor
Open

ci(ecr): build the combined mock_chain_validation-mock_balances flavor per ref#3756
bdchatham wants to merge 1 commit into
mainfrom
ci/ecr-combined-mock-flavor

Conversation

@bdchatham

Copy link
Copy Markdown
Contributor

The chaos harness suite consumes the combined mock_chain_validation-mock_balances seid flavor, which today is producible only by the nightly pipeline from main HEAD. A workflow_dispatch of ecr.yml for an arbitrary ref (the mechanism for validating a PR head against the harbor nightly harness) covers every other suite's flavor but not chaos.

Adds a fifth build step mirroring the nightly pipeline's combined-flavor step, using ecr.yml's shared build cache and tag scheme (mock_chain_validation-mock_balances-<ref>). Found while wiring full-harness validation of #3753 against its true head.

🤖 Generated with Claude Code

…r per ref

The chaos suite's flavor was producible only by the nightly pipeline from
main HEAD; a workflow_dispatch for an arbitrary ref could cover every other
harness suite but not chaos. Mirrors the nightly step with ecr.yml's shared
cache and tag scheme.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has reached its monthly code review spending cap.

An organization admin can view or raise the cap at claude.ai/admin-settings/claude-code. The cap resets at the start of the next billing period.

Once the cap resets or is raised, push a new commit or reopen this pull request to trigger a review.

@cursor

cursor Bot commented Jul 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only workflow addition; no runtime, auth, or application code changes.

Overview
Adds a fifth ECR publish step in ecr.yml that builds and pushes seid with both mock_balances and mock_chain_validation Go tags—the image the chaos harness expects for fresh-chain replays with pre-funded accounts.

The new step sits alongside the existing single-tag mock variants and uses the same shared registry build cache and ref-based tag pattern (mock_chain_validation-mock_balances-<ref>). workflow_dispatch (or push) for an arbitrary ref can now produce that combined flavor, which previously only nightly-ecr built from main.

Reviewed by Cursor Bugbot for commit dd93779. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJul 14, 2026, 8:43 PM

@seidroid seidroid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a fifth ECR build step that produces the combined mock_chain_validation-mock_balances seid flavor for an arbitrary ref, mirroring the existing mock-flavor steps exactly. The change is correct, consistent, and safe to merge.

Findings: 0 blocking | 2 non-blocking | 0 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • The Cursor second-opinion review file (cursor-review.md) was empty — that pass produced no output. Codex reported no material issues, and REVIEW_GUIDELINES.md was empty.
  • Verified against the Dockerfile: GO_BUILD_TAGS is expanded into BUILD_TAGS="netgo ledger ${GO_BUILD_TAGS}", so the space-separated mock_balances mock_chain_validation value correctly resolves to two build tags. The new step's cache, platform, and tag-fallback settings match the surrounding steps.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.02%. Comparing base (49f4d34) to head (dd93779).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3756      +/-   ##
==========================================
- Coverage   59.93%   59.02%   -0.92%     
==========================================
  Files        2288     2201      -87     
  Lines      189868   180025    -9843     
==========================================
- Hits       113793   106255    -7538     
+ Misses      65942    64438    -1504     
+ Partials    10133     9332     -801     
Flag Coverage Δ
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 87 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant