[akleshchev]

1. Don't load massive inventory in one go on startup, only apply crititcal folders. Make sure to follow links.
2. Apply remaining cache in a manned similar to AIS, as if folders are being loaded from network. Follow links and invoke callbacks.

Notes:

• Technically don't need to wait for the library to parse at skeleton stage, but it's comparatively small and uniform handling is easier.
• Potentially can split priority cache for early load, with the rest unpacking and parsing after the skeleton, but such improvements can be done later.

[Copilot]

🟡 Changes recommended

Fetch routing and cache-consistency defects can leave inventory missing, incomplete, or stale.

8 open findings

• Validate cached link targets against parent cache versions · New
• Use inventory capability when selecting agent-folder endpoint · New
• Restore cached thumbnails and favorite flags for deferred folders · New
• Update child counts when restoring recovered links · New
• Resolve folder links through the category map · New
• Reject folders with unresolved links and preserve observer notifications · New
• Update deferred folder descendant counts after merging children · New
• Limit cache-hit work to enforce inventory loading time budgets · New

What changed in this PR

This PR reduces startup inventory work by loading priority folders first and applying the remaining cached contents through background fetching.

Changes:

• Adds shared cache results with priority-folder and child-item indexes.
• Integrates deferred cache loading, link resolution, and invalidation into background fetching.
• Updates the cache format and narrows verbose AIS logging.

File	Description
indra/​newview/​llinventorymodelbackgroundfetch.h	Declares deferred-cache handling and ownership-aware callbacks.
indra/​newview/​llinventorymodelbackgroundfetch.cpp	Applies deferred contents during background fetching.
indra/​newview/​llinventorymodel.h	Updates cache types and serialization interfaces.
indra/​newview/​llinventorymodel.cpp	Saves priorities and separates startup from deferred loading.
indra/​newview/​llinventorycache.h	Defines shared cache results and bookkeeping.
indra/​newview/​llaisapi.cpp	Restricts response logging to the AIS3 tag.
indra/​newview/​CMakeLists.txt	Registers the new cache header.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Link resolution can crash when a target’s parent was deleted and rejects valid cached targets in deferred folders.

2 open findings

• Handle deleted cached parents as unresolved links · New
• Accept validated deferred parents for cached links · New

8 resolved since last review

• Use inventory capability when selecting agent-folder endpoint
• Validate cached link targets against parent cache versions
• Limit cache-hit work to enforce inventory loading time budgets
• Update deferred folder descendant counts after merging children
• Reject folders with unresolved links and preserve observer notifications
• Resolve folder links through the category map
• Update child counts when restoring recovered links
• Restore cached thumbnails and favorite flags for deferred folders

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Non-AIS cache processing lacks a per-pass bound, and restored favorite flags lack the notification needed to refresh existing views.

2 open findings

• Emit UPDATE_FAVORITE when restoring favorite state · New
• Count cached folders toward the per-pass fetch budget · New

2 resolved since last review

• Handle deleted cached parents as unresolved links
• Accept validated deferred parents for cached links

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Large cached folders still merge without item-level batching, allowing prolonged main-thread stalls.

1 open finding

• Make deferred cache application resumable within item-level budgets · New

2 resolved since last review

• Count cached folders toward the per-pass fetch budget
• Emit UPDATE_FAVORITE when restoring favorite state

🧠 Review effort: Balanced