Minor fixes for object.update and object.publish - #161
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add regression coverage for deferred root-property metadata merging.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates object metadata handling so deferred values from object.update are merged into published objects.
Changes:
- Allows deferred permission fields.
- Merges root and linked-object metadata updates.
- Documents updated payload behavior.
| File | Summary |
|---|---|
src/webview/explorer/explorer.ts |
Allows missing next_owner permissions. |
packages/sl-ide-ws-client/src/objectcontentservice.ts |
Applies deferred root and linked-object metadata updates. |
packages/sl-ide-ws-client/src/objectcontentinterfaces.ts |
Extends update and permission interfaces. |
packages/sl-ide-ws-client/doc/Message_Interfaces.md |
Documents deferred metadata behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+138
to
+152
| if (msg.object_description !== undefined) | ||
| { | ||
| entry.object.object_description = msg.object_description; | ||
| } | ||
| if (msg.owner_id !== undefined) | ||
| { | ||
| entry.object.owner_id = msg.owner_id; | ||
| } | ||
| if (msg.permissions !== undefined) | ||
| { | ||
| entry.object.permissions = msg.permissions; | ||
| } | ||
| if (msg.can_save_back !== undefined) | ||
| { | ||
| entry.object.can_save_back = msg.can_save_back; |
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor updates for information coming back through an object.publish or an object.update.
Some information is not reliably available at publish time and may be filled in later through an update.