Restrict AI-Assisted CI check to PR commits on merge checkouts - #5145
Closed
polybassa wants to merge 1 commit into
Closed
Restrict AI-Assisted CI check to PR commits on merge checkouts#5145polybassa wants to merge 1 commit into
polybassa wants to merge 1 commit into
Conversation
actions/checkout builds a merge of the PR into the base branch, so rev-list from HEAD was also validating base-branch tips. Use HEAD^1..HEAD^2 when that merge topology is present. AI-Assisted: yes (Cursor Agent) Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5145 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 390 390
Lines 96936 96936
=======================================
Hits 78175 78175
Misses 18761 18761 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request,actions/checkoutbuilds a merge of the PR into the base branch (HEAD^1= base tip,HEAD^2= PR tip).check_commits.shpreviously walkedrev-listfromHEAD, so it also validated base-branch tips and false-failed when those commits lacked anAI-Assistedtrailer.HEAD^1..HEAD^2when that merge topology is present; keep the existing dated/PR_FETCH_DEPTHfallback otherwise.Split out of #5050 so the ASN.1 work stays independent of this CI fix.
Test plan
check_commitspasses on a PR whose tip commits all haveAI-Assistedtrailers even if master tip lacks onerev-listfallback