Fix dangling arch pointer in gen_bpf - #498
Open
virajmalia wants to merge 1 commit into
Open
virajmalia wants to merge 1 commit into
virajmalia wants to merge 1 commit into
Conversation
Signed-off-by: Viraj Malia <virajmalia2@gmail.com>
virajmalia
force-pushed
the
fix-bpf-cwe-562
branch
from
September 17, 2026 21:25
3fdfcd5 to
927e33e
Compare
virajmalia
marked this pull request as ready for review
September 17, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I ran a cppcheck scan on the repository and found 2 instances of
state->arch = &pseudo_archthat are not reset before 6 return paths:state->archhas a longer lifetime thanpseudo_archand the function_gen_bpf_build_bpfreturns without resettingstate->arch.Fix
state->arch = NULLbefore the return statementsWhy?
Verification