Skip to content

tool: refactor main to move out kernel configuration and binary generation - #584

Merged
midnightveil merged 2 commits into
seL4:mainfrom
sfulham:main
Jul 30, 2026
Merged

tool: refactor main to move out kernel configuration and binary generation#584
midnightveil merged 2 commits into
seL4:mainfrom
sfulham:main

Conversation

@sfulham

@sfulham sfulham commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Currently kernel configuration and image generation are embedded in the main function of Microkit Tool. This means that external applications that wish to use Microkit in their toolchain can't use the tool in their toolchain as a library. This refactors the main functions so that these functions can be used by external programs.

@sfulham
sfulham marked this pull request as ready for review July 30, 2026 03:22
@midnightveil

Copy link
Copy Markdown
Collaborator

@sfulham You'll need to fix gitlint. Also, could you squash commit 3 into the previous commit that createa that file?

@midnightveil

Copy link
Copy Markdown
Collaborator

So gitlint still complaining. Please see: https://sel4.systems/Contribute/git-conventions.html. Ther'es a length limit.

I would prefer it you keep commit 1 and 2 separated though, the kernel config & image generation are better as separate commits

@sfulham

sfulham commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

So gitlint still complaining. Please see: https://sel4.systems/Contribute/git-conventions.html. Ther'es a length limit.

I would prefer it you keep commit 1 and 2 separated though, the kernel config & image generation are better as separate commits

ah thank you, didn't realise there was a page for the convention!

@midnightveil

Copy link
Copy Markdown
Collaborator

You can also run the gitlint tool locally yourself. The config is this file.

sfulham added 2 commits July 30, 2026 14:50
Moves the kernel configuration logic outside of main.rs
into sel4.rs for reuse

Signed-off-by: Charlotte Fulham <charlotte.fulham@anu.edu.au>
Creates a new `build.rs` file for system image generation
related functions, and corresponding `build` function
that is now invoked in `main` and can be used elsewhere.

Signed-off-by: Charlotte Fulham <charlotte.fulham@anu.edu.au>
@midnightveil
midnightveil merged commit 32180a1 into seL4:main Jul 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants