Conversation
R-Palazzo
requested review from
amontanez24,
frances-h,
rwedge and
sarahmish
September 7, 2026 10:45
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2981 +/- ##
==========================================
- Coverage 98.07% 97.92% -0.16%
==========================================
Files 77 66 -11
Lines 8780 7757 -1023
==========================================
- Hits 8611 7596 -1015
+ Misses 169 161 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rwedge
reviewed
Sep 24, 2026
Comment on lines
+18
to
+25
| def get_subclasses(cls): | ||
| """Recursively find subclasses for the current class object.""" | ||
| subclasses = {} | ||
| for subclass in cls.__subclasses__(): | ||
| subclasses[subclass.__name__] = subclass | ||
| subclasses.update(get_subclasses(subclass)) | ||
|
|
||
| return subclasses |
Comment on lines
+170
to
+171
| if hasattr(parsed_value.dt, 'tz_localize'): | ||
| parsed_value = parsed_value.dt.tz_localize(None) |
| _parse_datetime64_value(val, datetime_format, ignore_timezone) for val in value | ||
| ]) | ||
|
|
||
| return _parse_datetime64_value(value, datetime_format, ignore_timezone) |
|
|
||
| if errors: | ||
| raise InvalidDataError(errors) | ||
|
|
Contributor
There was a problem hiding this comment.
this method was untested before this PR and remains untested
| return self.metadata.tables.get(self._table_name, SingleTableMetadata()) | ||
| return self.metadata.tables.get(self._table_name, _SingleTableMetadata()) | ||
|
|
||
| return self.metadata |
Contributor
There was a problem hiding this comment.
this return was untested before this PR and is still untested
| self._table_synthesizers[table_name]._data_processor.table_name = table_name | ||
| self._table_parameters[table_name].update(deepcopy(table_parameters)) | ||
|
|
||
| def _validate_all_tables(self, data): |
Contributor
There was a problem hiding this comment.
this method was untested before and remains untested
| if type(scale) not in (float, int) or not scale > 0: | ||
| table_names = list(self.get_metadata().tables) | ||
| if table_name not in table_names: | ||
| raise SynthesizerInputError(f"Table '{table_name}' does not exist in the metadata.") |
Contributor
There was a problem hiding this comment.
this scenario is not tested
Comment on lines
+235
to
+236
| except Exception: | ||
| continue |
Contributor
There was a problem hiding this comment.
this scenario wasn't tested before this PR and remains untested
| try: | ||
| formated_date = datetime.now().strftime(datetime_format) | ||
| formatted_date = datetime.now().strftime(datetime_format) | ||
| except Exception as exception: |
Contributor
There was a problem hiding this comment.
this exception scenario was untested before and remains untested
| """ | ||
| if output_folder_path == DISABLE_TMP_FILE: | ||
| # Temporary way of disabling the output file feature, used by HMA1. | ||
| return [None] |
sarahmish
approved these changes
Sep 25, 2026
frances-h
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2944
Resolve #2948
Resolve #2954
Resolve #2955
Resolve #2952
Resolve #2992
Resolve #2950
Resolve #2993
Resolve #2953
Resolve #2994
Resolve #2956
Resolve #2986
Resolve #2984
Resolve #2957
Resolve #2985
Resolve #2990
Resolve #2995
Resolve #3003