Skip to content

perf: replace functools.partial with closure in _query callback (100-200ns improvement - 1.3-1.6x speedup) #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mykaul wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perf: replace functools.partial with closure in _query callback (100-200ns improvement - 1.3-1.6x speedup) #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cassandra/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5040,7 +5040,11 @@ def _query(self, host, message=None, cb=None):
result_meta = self._bound_result_metadata

if cb is None:
cb = partial(self._set_result, host, connection, pool)
_set_result = self._set_result

# default-arg capture avoids late-binding of host/connection/pool in the closure
def cb(response, _h=host, _c=connection, _p=pool, _sr=_set_result):
_sr(_h, _c, _p, response)
Comment on lines +5043 to +5047

self.request_encoded_size = connection.send_msg(message, request_id, cb=cb,
encoder=self._protocol_handler.encode_message,
Expand Down
Loading