✨ 增加安装代码全屏预览 - #1743
Open
cyfung1031 wants to merge 3 commits into
Open
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Checklist / 检查清单
N/A — 本次没有关联 issue;这是用户请求的新功能。
Description / 描述
背景
安装/更新页面的代码预览原本固定在代码卡中,长脚本在窄视口或需要集中查看时不便阅读。
本次改动
code_fullscreen翻译,并为共享 Dialog 支持本地化关闭标签。实现考虑
内联与全屏编辑器使用互不冲突的 host id,并在两种模式间卸载/重新挂载,避免同时占用 Monaco 容器。全屏布局使用
h-dvh/w-dvw;移动端图标按钮提供 44×44 触控区域,桌面端保留紧凑视觉尺寸。已知限制
本次人工会话覆盖安装页在浅色/深色主题及
390×844移动视口的真实浏览器表现;更新态 diff 的就绪回归由 CodeEditor 与 CodePreview 测试覆盖,未在会话中另建远端更新脚本流程。建议审查重点
Verification / 验证
pnpm exec vitest run --no-coverage src/pages/install: 18 files, 231 tests passedpnpm exec vitest run --no-coverage src/pages/components/CodeEditor/index.test.tsx: 5 tests passedpnpm run lint: passed (Prettier, TypeScript, i18n, issue templates, ESLint)pnpm run build: passed; existing asset-size and Monaco critical-dependency warnings remainpnpm exec prettier --check ...: passedgit diff --check: passed5694ba90827e7c9963d7e20187b81df06d0c4cefwith no actionable findings.Screenshots / 截图
本地 throwaway 浏览器会话截图(未加入提交)验证了浅色/深色桌面视口
1280×720与移动视口390×844;全屏 Dialog 实测从x=0,y=0填满视口,移动入口按钮实测为44×44。截图保存在本地 gitignored 的e2e/scratch/fullscreen-code-preview/shots/。