Skip to content

refactor CJumpNode to use SCP_vector#7432

Open
Goober5000 wants to merge 1 commit into
scp-fs2open:masterfrom
Goober5000:claude/CJumpNode_vector
Open

refactor CJumpNode to use SCP_vector#7432
Goober5000 wants to merge 1 commit into
scp-fs2open:masterfrom
Goober5000:claude/CJumpNode_vector

Conversation

@Goober5000

@Goober5000 Goober5000 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Jump nodes previously used SCP_list; refactor to use SCP_vector. Also improve resource handling and life cycle management.

Follow-up to, and depends on, #7431. In draft pending sexp_tree changes.

@Goober5000 Goober5000 added the refactor A cleanup/restructure of a feature for speed, simplicity, and/or maintainability label May 7, 2026
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch 2 times, most recently from 3cffb57 to 543f1ef Compare May 8, 2026 06:04
@BMagnu BMagnu added the Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle label May 31, 2026
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch from 43d1390 to c76cf18 Compare June 12, 2026 06:57
@BMagnu BMagnu removed the Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle label Jul 5, 2026
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch from c76cf18 to d724e26 Compare July 6, 2026 07:29
@Goober5000
Goober5000 marked this pull request as ready for review July 6, 2026 07:29
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch from d724e26 to f9a3342 Compare July 7, 2026 01:05
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch from f9a3342 to 282cbd0 Compare July 14, 2026 04:57

@wookieejedi wookieejedi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup looks good

@Goober5000
Goober5000 marked this pull request as draft July 19, 2026 04:29
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch from 282cbd0 to 8509a17 Compare July 20, 2026 01:24
@Goober5000
Goober5000 marked this pull request as ready for review July 20, 2026 01:26
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch from 8509a17 to 8db58a3 Compare July 20, 2026 02:06
Jump nodes previously used SCP_list; refactor to use SCP_vector.  Also improve resource handling and life cycle management.

Follow-up to scp-fs2open#7431.
@Goober5000
Goober5000 force-pushed the claude/CJumpNode_vector branch from 8db58a3 to e4e653d Compare July 20, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor A cleanup/restructure of a feature for speed, simplicity, and/or maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants