Skip to content

🔧 Drop dead library parameter from Splitter.split() #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiWeiss merged 2 commits into from
Sep 2, 2026
Merged

🔧 Drop dead library parameter from Splitter.split() #610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed1bb24
🔧 Drop dead `library` parameter from `Splitter.split()`
MiWeiss Sep 2, 2026
89774e7
Merge remote-tracking branch 'origin/main' into chore/drop-splitter-s…
MiWeiss Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions bibtexparser/splitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,22 +285,17 @@ def _move_to_end_of_entry(self, first_key_start: int) -> tuple[list[Field], int,
end_index=after_field_mark.start(),
)

def split(self, library: Library | None = None) -> Library:
"""Split the bibtex-string into blocks and add them to the library.
def split(self) -> Library:
"""Split the bibtex-string into blocks and return them as a new library.

Args:
library: The library to add the blocks to. If None, a new library is created.
Returns:
The library with the added blocks.
A new library containing the split blocks.
"""
self._markiter = re.finditer(
r"(?<!\\)[\{\}\",=\n]|@[\w]*( |\t)*(?={)", self.bibstr, re.MULTILINE
)

if library is None:
library = Library()
else:
logger.info("Adding blocks to existing library.")
library = Library()

while True:
m = self._next_mark(accept_eof=True)
Expand Down
Loading