fix: mini player no longer overlaps a reader's own controls; chrome follows app theme, not the reading theme - #69
Merged
Conversation
…ollows app theme, not the reading theme Two follow-up reports from on-device use: - 'the mini player is over the book controls' when a book/reader screen is open. The floating mini player was only hidden on the dedicated Player screen (onPlayer); every EPUB/comic/PDF reader has its own floating bottom bar (page slider, chevrons) that the pill would sit on top of just the same. Renamed the check to onReadingSurface and extended it to the EPUB and page-format reader routes too -- playback keeps running, the pill just doesn't render over a screen that already has its own bottom controls, same as it already didn't for Player. - 'the reader shows pretty light themed controls when in dark mode ... the mini player stays dark, and i think it looks better when the controls match the main theme but the page can be different, sepia, white etc.' Reverses the previous session's chromeScheme change: the EPUB reader's chrome (ReaderBar, the progress slider) now takes the app's own light/dark setting again, same as the mini player and every other screen, instead of following whichever reading theme is selected. The reading theme still only changes the page background behind the WebView. The two unrelated correctness fixes from that same change -- onColorFor()'s contrast-ratio fix and ReaderBar's explicit contentColor -- both stay; they were never about which theme the chrome uses, only about it rendering legibly whichever one it's given. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M421Z8byhEsWKMq7eWWqDN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-up reports from on-device use:
"the mini player is over the book controls" when a book/reader screen is open
The floating mini player was only hidden on the dedicated Player screen
(
onPlayer); every EPUB/comic/PDF reader has its own floating bottom bar(page slider, chevrons) that the pill would sit on top of just the same.
Renamed the check to
onReadingSurfaceand extended it to the EPUB andpage-format reader routes too — playback keeps running, the pill just
doesn't render over a screen that already has its own bottom controls,
same as it already didn't for Player.
"the reader shows pretty light themed controls when in dark mode ... the mini player stays dark, and i think it looks better when the controls match the main theme but the page can be different, sepia, white etc."
Reverses the previous session's
chromeSchemechange: the EPUB reader'schrome (
ReaderBar, the progress slider) now takes the app's ownlight/dark setting again, same as the mini player and every other
screen, instead of following whichever reading theme is selected. The
reading theme still only changes the page background behind the
WebView. The two unrelated correctness fixes from that same change —onColorFor()'s contrast-ratio fix andReaderBar's explicitcontentColor— both stay; they were never about which theme the chromeuses, only about it rendering legibly whichever one it's given.
Could not verify locally this round — two other builds already running
from another session on this box — pushing for CI to verify compilation.
🤖 Generated with Claude Code