docs: refresh README's feature list and Coming Next; capture this session's hard-won lessons in CLAUDE.md - #68
Merged
Merged
Conversation
…sion's hard-won lessons in CLAUDE.md README: - 'What works today' was missing SSO sign-in, Browse (series/authors/ shelves), Search, and in-app update checks entirely -- all shipped in earlier PRs (#30, #31) but never documented here. - The EPUB and comic/PDF reader bullets didn't mention this session's additions: two more reading themes (black, forest), edge-tap page turning, and tap-the-middle-to-hide-controls immersive reading. - 'Coming next' listed SSO sign-in, dashboard rows, series/authors/ shelves, search, bookmarks and in-app updates -- every single one of which has already shipped. Replaced with a pointer to the issue tracker instead of inventing a new speculative list. CLAUDE.md: added three conventions this session's debugging turned up the hard way, so a future session doesn't rediscover them: - The EPUB reader's WebView can't be trusted to report its own size or fire a resize event; Compose's own measured layout is the only reliable source, which is why reader.open()/reader.resize() take explicit width/height instead of reading window.innerWidth/innerHeight on the page side. - Surface's automatic content-color inference silently breaks once its color param doesn't exactly equal a theme role color (e.g. one with a modified alpha) -- pass contentColor explicitly instead of relying on it, especially under a nested MaterialTheme override. - Never catch(e: Exception) around a suspend call that can be legitimately cancelled without rethrowing CancellationException first. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M421Z8byhEsWKMq7eWWqDN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only, no code changes.
README
shelves), Search, and in-app update checks entirely — all shipped in
earlier PRs (feat: dashboard rows, browse and search, bookmarks, in-app updates #30, feat: SSO sign-in through the server's OIDC provider #31) but never documented here.
additions: two more reading themes (black, forest), edge-tap page
turning, and tap-the-middle-to-hide-controls immersive reading.
shelves, search, bookmarks and in-app updates — every single one of
which has already shipped. Replaced with a pointer to the issue
tracker instead of inventing a new speculative list.
CLAUDE.md
Added three conventions this session's debugging turned up the hard way,
so a future session doesn't rediscover them:
fire a resize event; Compose's own measured layout is the only
reliable source, which is why
reader.open()/reader.resize()takeexplicit width/height instead of reading
window.innerWidth/innerHeighton the page side.
Surface's automatic content-color inference silently breaks once itscolorparam doesn't exactly equal a theme role color (e.g. one with amodified alpha) — pass
contentColorexplicitly instead of relying onit, especially under a nested
MaterialThemeoverride.catch (e: Exception)around a suspend call that can belegitimately cancelled without rethrowing
CancellationExceptionfirst.This is a docs-only change with no code touched, so no build/lint was run.
🤖 Generated with Claude Code