Repository navigation
Clarify wave-2 milestone and evidence coordination - #847
Merged
Merged
Conversation
Keep milestone call budgets advisory while preserving binding deadlines and lifetime ceilings. Record job-scoped capture gates, timing-instrumentation limits, and authoritative PR-body coordination without changing parity status. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 795b8521-6c2d-4090-b5df-437f3e2c0e36 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
marked this pull request as ready for review
October 16, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify wave-2 milestone enforcement and retain the runtime/coordination lessons without changing product behavior, execution authority, or parity status.
Changes
Test plan
RED: pwsh -NoProfile -File Tools\tdd\Test-TddEvidence.ps1 -BodyPath .github\PULL_REQUEST_TEMPLATE.md -> exit 1, "RED evidence is still a placeholder." (one expected rejection; PR-body validation only, not runtime/product RED).
GREEN: pwsh -NoProfile -File Tools\tdd\Test-TddEvidence.ps1 -BodyPath "$env:GRAPHCODE_DOCS_PACKET\pr-body.md" -> exit 0, "TDD evidence: PASS" (one completed PR body accepted).
REGRESSION: pwsh -NoProfile -File Tools\tdd\Tests\TddEvidence.Tests.ps1; pwsh -NoProfile -File Tools\windows\validate.ps1 -Task privacy; git --no-pager diff --check -> both scripts exit 0 with one suite PASS and one privacy success summary; diff exits 0 with no whitespace errors.
GRAPHCODE_DOCS_PACKETnames the session-private packet directory;TEMPandTMPwere scoped there for validation. These are existing documentation/body/privacy checks, not product regression or a new gate. The checker suite emits one completion marker, not a test-runner case count.The initial immutable transfer's
git apply --checkexited 1 at kickoff hunk 115 before repository edits. Its hash and actual error were retained; the coordinator explicitly authorized context-only manual integration with the original deadline and file scope unchanged. The patch was not forced or silently retried.Not verified: product builds,
make test,make check, native/runtime behavior, GUI/capture, keyboard input, accessibility, rendering, persistence, or cross-platform/visual parity. No product/harness/source changes, images, ledger edits, or new execution grants. Historical Gjp8/Windows 2025 results are coordinator-supplied retrospective facts, not runs performed by this documentation owner. Actor-cleanup cause remains unobserved (#846); the body-guard failure does not establish an API race.Publication status: publication is limited to a signed-off, pushed, docs-only draft; this PR grants no runtime or desktop lease. Exact-head checks must be satisfied before readiness and merge; coordinator/operator own those transitions.
Checklist
git commit -s) per the DCOmake test)make check)Unchecked items are intentional: product build/test/lint commands are outside this docs-only lease, and the existing template rejection is body-validation RED rather than a newly authored product contract.