Skip to content

Clarify wave-2 milestone and evidence coordination - #847

Merged
coneilen merged 1 commit into
scgopi:mainfrom
coneilen:coneilen-wave-2-policy-lessons
Oct 16, 2026
Merged

coneilen merged 1 commit into
scgopi:mainfrom
coneilen:coneilen-wave-2-policy-lessons

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Clarify wave-2 milestone enforcement and retain the runtime/coordination lessons without changing product behavior, execution authority, or parity status.

Changes

  • Preserve the coordinator's 51 transferred policy/retrospective insertions, reanchored to current main without deleting any existing text: advisory milestone call budgets, binding time/outcome boxes, unchanged lifetime ceilings, bounded coordinator-authorized mechanical recovery, and PowerShell interpolation preflight.
  • Record job-scoped capture gates, timing instrumentation inside the existing read budget, and authoritative PR-body coordination. Retain failed attempts and distinguish observed results from unobserved causes.
  • Change only the canonical kickoff and orchestration plan. All 98 ledger identities/statuses remain unchanged at 6 Validated / 89 Partial / 3 Out of scope; B/C/D/E live visual acceptance remains NotExecuted (Windows capture core: journal check-then-open race fails UiCaptureDriver tests intermittently on main #826).

Test plan

RED: pwsh -NoProfile -File Tools\tdd\Test-TddEvidence.ps1 -BodyPath .github\PULL_REQUEST_TEMPLATE.md -> exit 1, "RED evidence is still a placeholder." (one expected rejection; PR-body validation only, not runtime/product RED).
GREEN: pwsh -NoProfile -File Tools\tdd\Test-TddEvidence.ps1 -BodyPath "$env:GRAPHCODE_DOCS_PACKET\pr-body.md" -> exit 0, "TDD evidence: PASS" (one completed PR body accepted).
REGRESSION: pwsh -NoProfile -File Tools\tdd\Tests\TddEvidence.Tests.ps1; pwsh -NoProfile -File Tools\windows\validate.ps1 -Task privacy; git --no-pager diff --check -> both scripts exit 0 with one suite PASS and one privacy success summary; diff exits 0 with no whitespace errors.

GRAPHCODE_DOCS_PACKET names the session-private packet directory; TEMP and TMP were scoped there for validation. These are existing documentation/body/privacy checks, not product regression or a new gate. The checker suite emits one completion marker, not a test-runner case count.

The initial immutable transfer's git apply --check exited 1 at kickoff hunk 115 before repository edits. Its hash and actual error were retained; the coordinator explicitly authorized context-only manual integration with the original deadline and file scope unchanged. The patch was not forced or silently retried.

Not verified: product builds, make test, make check, native/runtime behavior, GUI/capture, keyboard input, accessibility, rendering, persistence, or cross-platform/visual parity. No product/harness/source changes, images, ledger edits, or new execution grants. Historical Gjp8/Windows 2025 results are coordinator-supplied retrospective facts, not runs performed by this documentation owner. Actor-cleanup cause remains unobserved (#846); the body-guard failure does not establish an API race.

Publication status: publication is limited to a signed-off, pushed, docs-only draft; this PR grants no runtime or desktop lease. Exact-head checks must be satisfied before readiness and merge; coordinator/operator own those transitions.

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure

Unchecked items are intentional: product build/test/lint commands are outside this docs-only lease, and the existing template rejection is body-validation RED rather than a newly authored product contract.

Keep milestone call budgets advisory while preserving binding deadlines and
lifetime ceilings. Record job-scoped capture gates, timing-instrumentation
limits, and authoritative PR-body coordination without changing parity status.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 795b8521-6c2d-4090-b5df-437f3e2c0e36
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen marked this pull request as ready for review October 16, 2026 19:31
@coneilen
coneilen merged commit 95a1268 into scgopi:main Oct 16, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant