Skip to content

Fix fixture compile-log sharing races #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coneilen merged 1 commit into from
Oct 16, 2026
+57 −6
Merged

Fix fixture compile-log sharing races #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 57 additions & 6 deletions Tools/windows/Tests/UiCaptureDriver.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,53 @@ function Invoke-CapBoundedChild {
}
}

function Read-CapCompileLogSnapshot {
param([Parameter(Mandatory)][string]$Path)

if (-not (Test-Path -LiteralPath $Path -PathType Leaf)) {
return [pscustomobject]@{ Text = ''; Sha256 = $null }
}

$fileStream = $null
$snapshot = $null
try {
$fileStream = [IO.File]::Open(
$Path,
[IO.FileMode]::Open,
[IO.FileAccess]::Read,
([IO.FileShare]::ReadWrite -bor [IO.FileShare]::Delete)
)
$snapshot = [IO.MemoryStream]::new()
$fileStream.CopyTo($snapshot)
$bytes = $snapshot.ToArray()
} finally {
if ($null -ne $snapshot) { $snapshot.Dispose() }
if ($null -ne $fileStream) { $fileStream.Dispose() }
}

$textStream = [IO.MemoryStream]::new($bytes)
$reader = $null
try {
$reader = [IO.StreamReader]::new($textStream, [Text.Encoding]::UTF8, $true, 1024, $true)
$text = $reader.ReadToEnd()
} finally {
if ($null -ne $reader) { $reader.Dispose() }
$textStream.Dispose()
}

$hashAlgorithm = [Security.Cryptography.SHA256]::Create()
try {
$digest = $hashAlgorithm.ComputeHash($bytes)
} finally {
$hashAlgorithm.Dispose()
}

return [pscustomobject]@{
Text = $text
Sha256 = ([BitConverter]::ToString($digest)).Replace('-', '')
}
}

function New-CapHarmlessTarget {
$fixture = Join-Path $scratch 'fixture'
$null = New-Item -ItemType Directory -Path $fixture
Expand Down Expand Up @@ -657,17 +704,19 @@ int wmain(int argc, wchar_t **argv) {
-Directory $fixture -Role 'harmless-fixture-compile' -Seconds 90 -Environment $compilerEnvironment
# Preserve the actual compiler exit before reading the owned compile logs.
$compilerExitCode = $build.exitCode
$compileStdoutText = if (Test-Path -LiteralPath $compileStdout -PathType Leaf) { [IO.File]::ReadAllText($compileStdout) } else { '' }
$compileStderrText = if (Test-Path -LiteralPath $compileStderr -PathType Leaf) { [IO.File]::ReadAllText($compileStderr) } else { '' }
$compileStdoutSnapshot = Read-CapCompileLogSnapshot -Path $compileStdout
$compileStderrSnapshot = Read-CapCompileLogSnapshot -Path $compileStderr
$compileStdoutText = $compileStdoutSnapshot.Text
$compileStderrText = $compileStderrSnapshot.Text
Assert-CapTest ($compilerExitCode -eq 0 -and (Test-Path -LiteralPath $exe -PathType Leaf)) `
"Harmless target compilation failed (not launch evidence): $compileStdoutText $compileStderrText"
$provenance = [ordered]@{
compiler = $compiler; compilerVersion = (Get-Item -LiteralPath $compiler).VersionInfo.FileVersion
compilerSha256 = (Get-FileHash -LiteralPath $compiler -Algorithm SHA256).Hash
compilerCommand = $command; compilerExitCode = $compilerExitCode
compileStdoutLog = $compileStdout; compileStderrLog = $compileStderr
compileStdoutSha256 = if (Test-Path -LiteralPath $compileStdout -PathType Leaf) { (Get-FileHash -LiteralPath $compileStdout -Algorithm SHA256).Hash } else { $null }
compileStderrSha256 = if (Test-Path -LiteralPath $compileStderr -PathType Leaf) { (Get-FileHash -LiteralPath $compileStderr -Algorithm SHA256).Hash } else { $null }
compileStdoutSha256 = $compileStdoutSnapshot.Sha256
compileStderrSha256 = $compileStderrSnapshot.Sha256
source = $sourcePath; sourceSha256 = (Get-FileHash -LiteralPath $sourcePath -Algorithm SHA256).Hash
executable = $exe; executableSha256 = (Get-FileHash -LiteralPath $exe -Algorithm SHA256).Hash
}
Expand Down Expand Up @@ -751,8 +800,10 @@ int wmain(void) {
-Directory $fixture -Role 'cim-race-fixture-compile' -Seconds 90 -Environment $compilerEnvironment
# Preserve the actual compiler exit before reading the owned compile logs.
$compilerExitCode = $build.exitCode
$compileStdoutText = if (Test-Path -LiteralPath $compileStdout -PathType Leaf) { [IO.File]::ReadAllText($compileStdout) } else { '' }
$compileStderrText = if (Test-Path -LiteralPath $compileStderr -PathType Leaf) { [IO.File]::ReadAllText($compileStderr) } else { '' }
$compileStdoutSnapshot = Read-CapCompileLogSnapshot -Path $compileStdout
$compileStderrSnapshot = Read-CapCompileLogSnapshot -Path $compileStderr
$compileStdoutText = $compileStdoutSnapshot.Text
$compileStderrText = $compileStderrSnapshot.Text
Assert-CapTest ($compilerExitCode -eq 0 -and (Test-Path -LiteralPath $exe -PathType Leaf)) `
"CIM race target compilation failed (not launch evidence): $compileStdoutText $compileStderrText"
return [pscustomobject]@{
Expand Down
Loading