Skip to content

Fix Windows Stop UI synchronization - #647

Merged
coneilen merged 1 commit into
mainfrom
coneilen-fix-windows-stop-sync
Oct 7, 2026
Merged

coneilen merged 1 commit into
mainfrom
coneilen-fix-windows-stop-sync

Conversation

@coneilen

@coneilen coneilen commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the Windows shell's stale Stop UI after the daemon successfully stops a loop. The shell now decodes the Swift daemon's synthesized LoopState object payload instead of silently replacing it with idle.

Changes

  • decode every supported daemon loop state from both production object payloads and legacy string fixtures
  • reject unknown or malformed populated state objects without replacing the current graph
  • cover an already-open terminal workspace receiving stopped, retaining its selected node, and removing the Stop control

Test plan

RED: zig test src\App.zig --test-filter "open workspace applies production stopped state" -> expected stopped, found idle; 0 passed, 1 failed
GREEN: zig test src\App.zig --test-filter "open workspace applies production stopped state" -> All 1 tests passed
REGRESSION: zig test src\App.zig with native provider/link inputs -> All 773 tests passed

  • zig test src\GraphModel.zig -> All 155 tests passed
  • Tools\windows\validate.ps1 -Task windows-shell -ShellPart integration -SkipTrayLive -ShellValidationRoot C:\v -> passed; live shell/UIA integration and REAL_DAEMON_ROUNDTRIP: PASS
  • No shared Swift or macOS production files changed, so no macOS build was run.

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen merged commit af3d006 into main Oct 7, 2026
24 checks passed
@coneilen
coneilen deleted the coneilen-fix-windows-stop-sync branch October 7, 2026 07:23
coneilen added a commit that referenced this pull request Oct 7, 2026
Record the immutable, unpublished 0.1.78-windows.beta13 candidate built from
af3d006 with #647's Stop UI state-decoding fix. Beta12 is failed/superseded
and kept unchanged. Exact artifact stays complete; the other six gates and
the 98/60/38 parity ledger are unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen coneilen mentioned this pull request Oct 7, 2026
2 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant