Repository navigation
Remove a committed validation workspace layout and ignore new ones - #645
Merged
Merged
Conversation
#644 accidentally committed graphcode-workspace.159bee7166972fae.json, a workspace layout the Windows shell wrote into the repository root during a local windows-shell validation run (it holds a scratch project path and fixture UUIDs only). Remove it and ignore root-level graphcode-workspace.*.json so local validation runs cannot add another. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#644 accidentally committed
graphcode-workspace.159bee7166972fae.jsonbecauseit was staged with
git add -A. The Windows shell wrote that workspace layoutinto the repository root during a local
windows-shellvalidation run. Itcontains only a scratch project path and fixture UUIDs, nothing sensitive. This
PR removes the file and ignores root-level
graphcode-workspace.*.jsonso alocal run cannot add another.
Changes
graphcode-workspace.159bee7166972fae.json./graphcode-workspace.*.jsonto.gitignore. The rule is anchored to therepository root, so it does not hide any intentional fixture under another
directory.
Root cause, not changed here: unless
GRAPHCODE_WORKSPACE_LAYOUTis set,TerminalSurface.Workspace.layoutPathForProjectuses a relativegraphcode-workspace.<key>.json. Layouts are therefore written to the shell'scurrent directory. A product fix that places them under the support directory
needs a separate decision and its own evidence.
Test plan
RED: git check-ignore -v graphcode-workspace.0000.json before the change -> exit 1, no rule matched; the file from #644 was tracked at main ed30b0c
GREEN: git check-ignore -v graphcode-workspace.0000.json after the change -> .gitignore:70:/graphcode-workspace..json matched; git ls-files graphcode-workspace -> no output
REGRESSION: create root graphcode-workspace.regression-probe.json, then git status --porcelain -> 0 lines (file ignored, worktree otherwise clean)
make testandmake checkwere not run.Checklist
git commit -s) per the DCOmake test)make check)