Correct the Dev Box Stop qualification contract - #637
Merged
Merged
Conversation
Stop is reversible: a reachable loop session receives the daemon's stop request and stays alive, and only an unreachable session is killed. Require the memory-log path to match the observed session state, protect owned sentinel sessions, and stop requiring a reachable session to end. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The beta9 Dev Box run failed section 6A because the runbook required Stop loop
to end the loop's zmx session. Stop is the reversible verb. For a reachable
session,
GraphStore.requestStoptypesMessageBus.stopRequestinto it — arequest that tells the agent to stay in the session — and kills the session only
when it cannot be reached. This PR replaces that expectation with the contract
the product actually implements, and makes the daemon's memory-log claim the
thing that is checked.
Changes
investigation/windows-preview-devbox-qualification-plan.md: add a Stopcontract under D7.
stopped, no other loop changes state,owned sentinel sessions (one unprefixed and one
graphcode-decoy) keeptheir PIDs and receive no input, and the shell and daemon stay responsive.
looping" means the session survives and shows the request; "could not be
reached, so it was killed" means the session is gone within 15 s.
TerminalSessionOwnershipfailure. That is the beta9 result, caused by thepackaged daemon not locating
zmx, which is a separate product fix.investigation/windows-preview-release-plan.md: note that the beta9prompt's "Stop must end the session" step is superseded by this contract.
The immutable beta9 handoff copy of the plan is unchanged; the next handoff
should ship this version. The plan file keeps its existing CRLF line endings, so
git diff --checkreports CR on its added lines by convention; the releaseplan is clean.
Test plan
Documentation only; no product code or test changed. Evidence is a check that
the contract is absent on the base and present on this branch, plus a link check.
RED: git show origin/main:investigation/windows-preview-devbox-qualification-plan.md, Select-String for the Stop contract heading and the asked-to-stop-looping path -> 0 matching lines
GREEN: same Select-String against HEAD -> 2 matching lines
REGRESSION: Select-String for the stop-contract anchor heading plus git diff --check on investigation/windows-preview-release-plan.md -> 1 heading, exit 0
The underlying behaviour was observed on the beta9 Dev Box:
with the same PID;
zmxreachable (diagnostic): the log said the session was asked to stoplooping, and it survived as designed.
make testandmake checkwere not run; nothing they cover changed.Checklist
git commit -s) per the DCOmake test) — not run: documentation-only change, macOS-only targetmake check) — not run: no Swift changed