Repository navigation
S3UTILS-248: move to Node 24 - #410
Closed
francoisferrand wants to merge 1 commit into
Closed
francoisferrand wants to merge 1 commit into
francoisferrand wants to merge 1 commit into
Conversation
Node 22 enters maintenance in October and 24 is the active LTS until 2028, so CI, the image and the engines floor all move to 24. Two native dependencies did not survive the ABI/toolchain change: - bucketclient 8.2.6 carried its own Arsenal 8.2.4, which pulled diskusage — unmaintained since 2021 and still on the pre-Node-24 NAN API. 8.2.10 takes Arsenal as a peer dependency, so we get a single copy (ours) and diskusage disappears from the tree. - node-rdkafka 2.x builds with C++17, while the Node 24 headers need C++20. Fixed in 3.x; the Producer API we use is unchanged. Issue: S3UTILS-248
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the org-wide Node 24 upgrade (OS-1155). Raises the engines floor and moves CI and the image to Node 24.
Two things broke along the way:
diskusagefails to build on Node 24 — it uses a NAN API V8 removed, and is unmaintained since 2021. It only reached us through a stale nestedarsenal#8.2.4dragged in bybucketclient#8.2.6;bucketclient#8.2.10makes Arsenal a peer dependency, so the duplicate (and diskusage with it) drops out of the tree.node-rdkafka2.x builds with C++17, which no longer compiles against Node 24's v8/cppgc headers. 3.x builds with C++20.Validated on Node 24.21.0: install, lint, 32 unit suites / 472 tests, plus a docker build and an in-image require of arsenal/bucketclient/node-rdkafka.
Issue: S3UTILS-248