Skip to content

S3UTILS-248: move to Node 24 - #410

Closed
francoisferrand wants to merge 1 commit into
development/1from
improvement/S3UTILS-248-node-24
Closed

francoisferrand wants to merge 1 commit into
development/1from
improvement/S3UTILS-248-node-24

Conversation

@francoisferrand

Copy link
Copy Markdown
Contributor

Part of the org-wide Node 24 upgrade (OS-1155). Raises the engines floor and moves CI and the image to Node 24.

Two things broke along the way:

  • diskusage fails to build on Node 24 — it uses a NAN API V8 removed, and is unmaintained since 2021. It only reached us through a stale nested arsenal#8.2.4 dragged in by bucketclient#8.2.6; bucketclient#8.2.10 makes Arsenal a peer dependency, so the duplicate (and diskusage with it) drops out of the tree.
  • node-rdkafka 2.x builds with C++17, which no longer compiles against Node 24's v8/cppgc headers. 3.x builds with C++20.

Validated on Node 24.21.0: install, lint, 32 unit suites / 472 tests, plus a docker build and an in-image require of arsenal/bucketclient/node-rdkafka.

Issue: S3UTILS-248

Node 22 enters maintenance in October and 24 is the active LTS until 2028,
so CI, the image and the engines floor all move to 24.

Two native dependencies did not survive the ABI/toolchain change:

- bucketclient 8.2.6 carried its own Arsenal 8.2.4, which pulled diskusage —
  unmaintained since 2021 and still on the pre-Node-24 NAN API. 8.2.10 takes
  Arsenal as a peer dependency, so we get a single copy (ours) and diskusage
  disappears from the tree.
- node-rdkafka 2.x builds with C++17, while the Node 24 headers need C++20.
  Fixed in 3.x; the Producer API we use is unchanged.

Issue: S3UTILS-248
@bert-e

bert-e commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue S3UTILS-248 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.20.0

Please check the Fix Version/s of S3UTILS-248, or the target
branch of this pull request.

@francoisferrand
francoisferrand deleted the improvement/S3UTILS-248-node-24 branch September 25, 2026 09:41
@francoisferrand
francoisferrand restored the improvement/S3UTILS-248-node-24 branch September 25, 2026 10:04
@bert-e
bert-e deleted the improvement/S3UTILS-248-node-24 branch September 25, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants