Skip to content

CLDSRV-955: Cache node_modules instead of yarn download cache #6227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bert-e merged 2 commits into from
Jul 15, 2026
+51 −8
Merged

CLDSRV-955: Cache node_modules instead of yarn download cache #6227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a66ac
CLDSRV-955: Cache node_modules instead of yarn download cache
tcarmet Jul 9, 2026
b9c4715
CLDSRV-955: Satisfy prettier on setup-ci action.yaml
tcarmet Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions .github/actions/setup-ci/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: "Setup CI environment"
description: "Setup Cloudserver CI environment"
name: 'Setup CI environment'
description: 'Setup Cloudserver CI environment'

runs:
using: composite
Expand All @@ -26,16 +26,29 @@ runs:
set -exu;
mkdir -p /tmp/coverage/${JOB_NAME}/;
- uses: actions/setup-node@v4
id: node
with:
node-version: '22.23.1'
cache: 'yarn'
# Cache node_modules directly (not the yarn download cache) so the git
# dependencies' TypeScript compilation and relink are skipped on a hit.
# Key includes runner.os and the resolved Node version because node_modules
# can hold native addons compiled for a specific OS/Node; the Node version
# is taken from the setup-node output rather than hardcoded.
- name: Cache node_modules
id: cache-node-modules
uses: actions/cache@v6
with:
path: node_modules
key: ${{ runner.os }}-node-${{ steps.node.outputs.node-version }}-modules-${{ hashFiles('yarn.lock') }}
- name: install typescript
shell: bash
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn global add typescript@4.9.5
- name: install dependencies
shell: bash
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn install --ignore-engines --frozen-lockfile --network-concurrency 1
- uses: actions/cache@v3
- uses: actions/cache@v6
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip
Expand Down
38 changes: 34 additions & 4 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,21 @@ jobs:
with:
fetch-depth: 0
- uses: actions/setup-node@v4
id: node
with:
node-version: '22.23.1'
cache: yarn
- name: Cache node_modules
id: cache-node-modules
uses: actions/cache@v6
with:
path: node_modules
key: ${{ runner.os }}-node-${{ steps.node.outputs.node-version }}-modules-${{ hashFiles('yarn.lock') }}
- name: install typescript
shell: bash
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn global add typescript@4.9.5
- name: install dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile --network-concurrency 1
- uses: actions/setup-python@v5
with:
Expand Down Expand Up @@ -125,10 +133,17 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-node@v4
id: node
with:
node-version: '22.23.1'
cache: yarn
- name: Cache node_modules
id: cache-node-modules
uses: actions/cache@v6
with:
path: node_modules
key: ${{ runner.os }}-node-${{ steps.node.outputs.node-version }}-modules-${{ hashFiles('yarn.lock') }}
- name: install dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile --network-concurrency 1
- name: Count async/await migration progress
run: yarn run count-async
Expand All @@ -139,13 +154,21 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-node@v4
id: node
with:
node-version: '22.23.1'
cache: yarn
- name: Cache node_modules
id: cache-node-modules
uses: actions/cache@v6
with:
path: node_modules
key: ${{ runner.os }}-node-${{ steps.node.outputs.node-version }}-modules-${{ hashFiles('yarn.lock') }}
- name: install typescript
shell: bash
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn global add typescript@4.9.5
- name: install dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile --network-concurrency 1
- name: Unit Coverage
run: |
Expand Down Expand Up @@ -1087,10 +1110,17 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-node@v4
id: node
with:
node-version: '22.23.1'
cache: yarn
- name: Cache node_modules
id: cache-node-modules
uses: actions/cache@v6
with:
path: node_modules
key: ${{ runner.os }}-node-${{ steps.node.outputs.node-version }}-modules-${{ hashFiles('yarn.lock') }}
- name: Install dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile --network-concurrency 1
- name: Delete stale GCP CI buckets
run: yarn run cleanup_gcp_buckets
Expand Down
Loading