Repository navigation
BB-916: Shared Claude Code skeleton setup for BNaaS D1 - #2887
Open
anurag4DSB wants to merge 3 commits into
Open
anurag4DSB wants to merge 3 commits into
anurag4DSB wants to merge 3 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## epic/S3C-10971-bnaas-d1 #2887 +/- ##
===========================================================
- Coverage 81.36% 81.21% -0.15%
===========================================================
Files 209 209
Lines 44236 44236
===========================================================
- Hits 35993 35928 -65
- Misses 8243 8308 +65
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
anurag4DSB
changed the title
Both developers need the same Claude Code setup on D1, and it lived in one local checkout only. This adds it under .claude/ on the backbeat epic. The final merge into development removes it. - rules/bnaas-d1.md: team rules 1 to 6 (advisor and subagents, plan first, epic PRs, verification, Jira tracking, commits and releases). - agents/bnaas-reviewer.md: a read-only reviewer for diffs and plans. - skills/bnaas-plan-pr: commits an approved plan and opens a plan PR. - settings.json: Fable as the advisor, plans/ as the plans folder. - README.md: install for the one-repository and workspace layouts. - plans/: the approved plans of this setup and of task 3. .gitignore keeps settings.local.json and worktrees/ out of git.
Rule 7: before every push, run the review-pr skill of scality-skills@scality-agent-hub on the branch. It is the skill that the Code Review workflow runs on each PR. hooks/review-branch.sh runs it in a headless session, in its local mode, and saves the result per commit under the git dir. hooks/review-gate.sh, a PreToolUse hook on Bash, refuses a git push until a saved review exists for the exact commit being pushed. The gate catches a forgotten review. It is not a security boundary, and it fails closed on what it cannot check. The README covers the plugin install and each refusal message, and the plan PR skill runs the review before its push.
The files under .claude/ are prompts, rules and plans for Claude Code, with long lines and front matter that mdlint refuses (MD013, MD041). They live only on the BNaaS D1 epic and go away before the final merge, together with this exclusion.
anurag4DSB
force-pushed
the
improvement/BB-916-shared-claude-setup
branch
from
October 14, 2026 14:50
267fe0d to
2036d9d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to reviewers: Additions to only
.claude, plus.gitignoreentries for local.claudework files and alint_mdchange that skips.claude/. This is just skeleton, we will improve this as and when we neededIntent: why does this change exist?
This is a first shared Claude Code setup for D1, so that the sessions of Anurag and Taylor follow the same rules. It is a skeleton, and the team changes it to fit the work.
System impact: what's affected, including downstream?
Only
.claude/, plus two.gitignoreentries and onelint_mdline inpackage.jsonthat skips.claude/. A D1 session that follows the README install loads the setup.Preserved behavior: what explicitly stays the same?
Backbeat code, tests and CI are untouched.
Intended change: what's different after this PR?
The setup holds seven team rules, the
bnaas-revieweragent and thebnaas-plan-prskill. A hook refuses agit pushuntil the CI review ran locally on that commit (Rule 7). Start with.claude/README.md.Verification: how do we know this worked, or how would we know if it didn't?
A fresh session loads the setup, and the push gate passes 41 test cases. This branch went through the same local review before its push.