Repository navigation
ARSN-656: default untyped batch operations to put in file metadata backend - #2730
Conversation
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.6 #2730 +/- ##
================================================
Coverage 75.37% 75.38%
================================================
Files 226 226
Lines 18633 18633
Branches 3894 3863 -31
================================================
+ Hits 14045 14046 +1
+ Misses 4583 4582 -1
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Since the file metadata server moved to classic-level, batches are checked by abstract-level, which rejects operations without a type. level-sublevel used to treat them as puts, and the versioning layer still emits such operations, e.g. for any non-versioned put: cloudserver with the file backend fails at startup when writing the users bucket. Resolve the missing type to put along with the sublevel, so every batch reaching the database is well-formed again. Issue: ARSN-656
77c56c4 to
3ccf100
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
This pull request does not target the following hotfix branch(es) so they
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-656. Goodbye francoisferrand. |
Since 8.6.0-preview.4, the file metadata server goes through classic-level, and abstract-level rejects batch operations that have no
type. level-sublevel used to treat them as puts, and the versioning layer still sends such operations for every non-versioned put. As a result, cloudserver withS3BACKEND=filecrashes at startup:This breaks every file-backend job in scality/cloudserver#6320 (CLDSRV-1013).
resolveBatchSubLevelsnow sets a missing type toputwhile it resolves the sublevel, so all callers of the server batch path work again. The PR also bumps the version to 8.6.0-preview.5.Tested:
S3BACKEND=fileand this build: the server starts, and create bucket, put/get, and a versioned put all work.Issue: ARSN-656