Repository navigation
feat(release): dotskit is packed and published beside the template, as SawKing.DotsKit.Tool of the same version - #119
Merged
Merged
Conversation
…s SawKing.DotsKit.Tool of the same version - tool/DotsKit takes its version from version.json, as the template's package does; its package has a README of its own (tool/README.md), the template's icon and the release's notes - release.yml packs the tool into the same folder as the template, so it is attached to the GitHub release and pushed to nuget.org and GitHub Packages with it - nuget.org gets the tool first: a key that cannot push it stops the step before the template, which cannot be taken back, is out - template.yml packs the tool, installs it from the package and checks that dotskit --version is version.json's - the template's package README names dotskit and its commands; the notes of 2.8 name dotskit
…s from Program.cs, not from the environment - the scenarios set DOTSKIT_TEMPLATE_SOURCE in the test process, and a unit test of new that ran after one saw the version "source": it failed on the order of the tests (windows-2022 in #119) - NewCommand gets onSources from the composition root, as init and upgrade do; TemplateSource.Current, left without a caller, is removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool is released with the template, under one tag and one version.
tool/DotsKittakes its version fromversion.json, as the template's package does; its package has a README of its own (tool/README.md), the template's icon and the release's notes.release.ymlpacks the tool into the same folder as the template: it is attached to the GitHub release and pushed to nuget.org and GitHub Packages with it. nuget.org gets the tool first, so a key that cannot push it stops the step before the template, which cannot be taken back, is out.template.ymlpacks the tool, installs it from the package and checks thatdotskit --versionisversion.json's.Before 2.8 is released, outside the code: the nuget.org key (
NUGET_API_KEY) coversSawKing.DotNetSolutionKitonly and has to be reissued forSawKing.DotsKit.Toolas well; the site moves todotskit.sawking.tech(#108), which the tool's package names as its project page.release.ymlitself runs only at a release: what this PR proves in CI is the samedotnet pack tool/DotsKitintemplate.yml.Reviewed before the PR by an agent without context, two rounds, closed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vefp3uznXHA37YYMCkUouw