Repository navigation
fix(validate): treat services the emulator lacks as emulator gaps - #44
Merged
Merged
Conversation
Recent emulator versions answer unknown services with 404 UnknownService instead of 501. The e2e gap test now uses QLDB, since the emulator implements Athena workgroups.
keepstack validate:
|
| Step | Result |
|---|---|
| init | ✅ ok |
| plan | ✅ ok |
| apply | ✅ ok |
| idempotency | ✅ ok |
| smoke | ✅ ok |
Plan: 0 to add, 0 to change, 0 to replace, 0 to destroy
keepstack · 21.4 s · AWS Emulator, no AWS account used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43
The emulator (1.0.345) now answers services it does not emulate with
404 UnknownService: no emulated service is registered for '<service>'instead of 501, sokeepstack validatereported them as config errors. They are emulator gaps again (warning unless--strict).The emulator also implements
aws_athena_workgroupnow, which broketest_5_emulator_gap_only_warnson every PR. The test usesaws_qldb_ledger(QLDB is not emulated).scripts/verify.ps1against emulator 1.0.345: 141 tests OK.🤖 Generated with Claude Code