Skip to content

fix(proxy): translate random uppercase IDs without digits - #37

Merged
sanlega merged 1 commit into
mainfrom
fix/36-route53-letter-ids
Nov 13, 2026
Merged

sanlega merged 1 commit into
mainfrom
fix/36-route53-letter-ids

Conversation

@sanlega

@sanlega sanlega commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Closes #36

What and why

Found by the chaos suite (#34) on a clean restart: aws_route53_zone.internal (id ZSOVGDZPSPRJKSM) planned for creation again, 14 calls replayed, 0 failed, 13 values translated.

id_like requires letters and digits (Z0123ABC) to keep words out. Route 53 zone IDs are random uppercase alphanumerics, so sometimes they have no digit and the recorded/replayed pair is never learned. Same family as #24.

Without loosening id_like, IdMap.learn also accepts a pair when both tokens are uppercase alphanumeric, the same length (>= 12) and different (same_shape_new_id). The recorded and replayed responses answer the same request, so a long code that changed between them is generated. AWS enums of that length use underscores (CREATE_IN_PROGRESS, INSUFFICIENT_DATA) and are excluded, as are shorter codes and plain numbers.

How it was tested

  • test_route53_zone_id_without_digits (letters-only → mixed and mixed → letters-only, in the zone path and in the client direction): fails without the fix with b'/2013-04-01/hostedzone/ZSOVGDZPSPRJKSM' != b'/2013-04-01/hostedzone/Z3LV898WM8KOB1A', passes with it.
  • test_short_or_numeric_codes_are_not_ids: enums with underscores, an 11-character code and a 12-digit number are not learned.
  • tests.test_unit: 16 OK.

@sanlega sanlega added this to the v0.4.0 milestone Nov 13, 2026
@sanlega sanlega added type: bug Something is broken area: proxy Journal, replay, ID translation labels Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

keepstack validate: examples/quickstart ✅ passed

Step Result
init ✅ ok
plan ✅ ok
apply ✅ ok
idempotency ✅ ok
smoke ✅ ok

Plan: 0 to add, 0 to change, 0 to replace, 0 to destroy

keepstack · 16.8 s · AWS Emulator, no AWS account used

@sanlega
sanlega force-pushed the fix/36-route53-letter-ids branch from 8b02125 to 7521a30 Compare November 13, 2026 00:43
@sanlega
sanlega merged commit e4b1545 into main Nov 13, 2026
12 checks passed
@sanlega
sanlega deleted the fix/36-route53-letter-ids branch November 13, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: proxy Journal, replay, ID translation type: bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route 53 zone ID made only of letters is not translated after a restart

1 participant