Repository navigation
fix(proxy): translate random uppercase IDs without digits - #37
Merged
Merged
Conversation
keepstack validate:
|
| Step | Result |
|---|---|
| init | ✅ ok |
| plan | ✅ ok |
| apply | ✅ ok |
| idempotency | ✅ ok |
| smoke | ✅ ok |
Plan: 0 to add, 0 to change, 0 to replace, 0 to destroy
keepstack · 16.8 s · AWS Emulator, no AWS account used
sanlega
force-pushed
the
fix/36-route53-letter-ids
branch
from
November 13, 2026 00:43
8b02125 to
7521a30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
What and why
Found by the chaos suite (#34) on a clean restart:
aws_route53_zone.internal(idZSOVGDZPSPRJKSM) planned for creation again,14 calls replayed, 0 failed, 13 values translated.id_likerequires letters and digits (Z0123ABC) to keep words out. Route 53 zone IDs are random uppercase alphanumerics, so sometimes they have no digit and the recorded/replayed pair is never learned. Same family as #24.Without loosening
id_like,IdMap.learnalso accepts a pair when both tokens are uppercase alphanumeric, the same length (>= 12) and different (same_shape_new_id). The recorded and replayed responses answer the same request, so a long code that changed between them is generated. AWS enums of that length use underscores (CREATE_IN_PROGRESS,INSUFFICIENT_DATA) and are excluded, as are shorter codes and plain numbers.How it was tested
test_route53_zone_id_without_digits(letters-only → mixed and mixed → letters-only, in the zone path and in the client direction): fails without the fix withb'/2013-04-01/hostedzone/ZSOVGDZPSPRJKSM' != b'/2013-04-01/hostedzone/Z3LV898WM8KOB1A', passes with it.test_short_or_numeric_codes_are_not_ids: enums with underscores, an 11-character code and a 12-digit number are not learned.tests.test_unit: 16 OK.