Repository navigation
Conversation
hkay-dev
marked this pull request as ready for review
September 24, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-assisted: Codex helped write and review this code and PR.
Why
The receiver sent
ACCEPTbefore opening its Downloads output stream. The Mac could begin sending before Android was ready, leaving a pending file even when the sender reported success. During testing, duplicate discovery requests also registered a second mDNS service and coincided with the Mac staying on Connecting.What changed
ACCEPT. Require that stream for payload data, check the final byte count, and clear MediaStore's pending flag only for a complete file.Checks
:app:assembleDebugpasses./sdcard/Download/, matched the Mac copy by SHA-256, and hadis_pending=0in MediaStore.Notes
This changes inbound Quick Share and duplicate discovery only. Other Android file-saving paths are unchanged.
Companion Mac PR: sameerasw/airsync-mac#301