Use default values for properties missing from --settings file#125
Open
AmadeusW wants to merge 1 commit into
Open
Use default values for properties missing from --settings file#125AmadeusW wants to merge 1 commit into
AmadeusW wants to merge 1 commit into
Conversation
sameer
reviewed
Jul 9, 2026
| let settings = { | ||
| let mut settings = if let Some(path) = opt.settings { | ||
| serde_json::from_reader(File::open(path)?)? | ||
| let defaults = serde_json::to_value(Settings::default()).unwrap(); |
Owner
There was a problem hiding this comment.
Hmm I thought this was already possible, an easier way to do this might be to apply serde(default) to the settings struct itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use default values for properties missing from --settings file.
This allows for a minimal settings file, such as