Add set_command_time() - #19
Open
ThomasHabets wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for contributing. This looks good. Please add an entry for this to the changelog. |
ThomasHabets
force-pushed
the
set-command-time
branch
from
August 12, 2026 07:57
aeb05c9 to
94554a6
Compare
ThomasHabets
force-pushed
the
set-command-time
branch
from
August 12, 2026 07:57
94554a6 to
cd4768f
Compare
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the converting functions because in my opinion the
TimeSpecshould be treatable as an opaque type.I do wonder if nanos in this context should just be i128 in case some hardware sets it weird. i64 should be good until the year 2318, assuming the unix timestamp is even the set baseline. If 0 is the timespec baseline it's good for streaming for 292 years.