Skip to content

fix: label deploy zip count as Entries to match SDR files+folders count-W-24345651 - #1657

Merged
soridalac merged 2 commits into
mainfrom
wr/zipEntryCountNut
Oct 1, 2026
Merged

soridalac merged 2 commits into
mainfrom
wr/zipEntryCountNut

Conversation

@WillieRuemmele

@WillieRuemmele WillieRuemmele commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Notes

  • The verbose NUTs will fail until an SDR version containing #1844 is published and consumed here. This PR is what lets the SDR extNUTs pass against #1844.
  • zipSize assertions are unchanged — JSZip already emitted the folder entry; only the count changed.

@W-24345651@

Proof of Work

  • Unit tests: 134 passing (clean worktree, published deps)
  • Build + lint: clean

@soridalac soridalac changed the title fix: label deploy zip count as Entries to match SDR files+folders count fix: label deploy zip count as Entries to match SDR files+folders count-W-24345651 Oct 1, 2026
@soridalac
soridalac merged commit 30c58dd into main Oct 1, 2026
46 of 49 checks passed
@soridalac
soridalac deleted the wr/zipEntryCountNut branch October 1, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants