Skip to content

[Feat] Deploy DataSpace-Scoped Components with their retrieveWith Closure #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aparnagoy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Feat] Deploy DataSpace-Scoped Components with their retrieveWith Closure #1649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c270bc
feat: deploy dataspace-scoped components with their retrieveWith closure
Sep 21, 2026
9a6836b
refactor: follow SDR rename to d360 strategy and expandD360ComponentSet
Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/utils/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
ComponentStatus,
DeployResult,
DestructiveChangesType,
expandD360ComponentSet,
FileResponseSuccess,
MetadataApiDeploy,
MetadataApiDeployOptions,
Expand Down Expand Up @@ -119,6 +120,22 @@ export async function buildComponentSet(opts: Partial<DeployOptions>, stl?: Sour
});
}

/** True when the deploy includes at least one Data Cloud dataspace-scoped component. */
const hasD360Components = (requested: ComponentSet): boolean =>
[...requested.getSourceComponents()].some((c) => c.type.strategies?.adapter === 'd360');

/**
* A dataspace-scoped component's sidecar lists the peers it has to be deployed alongside, under
* `retrieveWith`. So when someone deploys one of these, we also pull in those peers (and their peers,
* and so on) — but nothing else from the project. To find them we resolve the whole project once,
* then hand back the requested set plus that closure.
*/
async function expandD360Closure(requested: ComponentSet, registry?: RegistryAccess): Promise<ComponentSet> {
// Resolve the whole project so we can look up the retrieveWith peers by their sidecar componentName.
const full = await ComponentSetBuilder.build({ sourcepath: await getPackageDirs() });
return expandD360ComponentSet(full, requested, registry);
}

export async function executeDeploy(
opts: Partial<DeployOptions>,
project?: SfProject,
Expand Down Expand Up @@ -166,6 +183,11 @@ export async function executeDeploy(
registry = stl.registry;

componentSet = await buildComponentSet(opts, stl);
// Dataspace-scoped components need their retrieveWith peers in the same deploy, so pull those in.
// Every other deploy leaves the component set untouched.
if (hasD360Components(componentSet)) {
componentSet = await expandD360Closure(componentSet, registry);
}
if (componentSet.size === 0) {
if (opts['source-dir'] ?? opts.manifest ?? opts.metadata ?? throwOnEmpty) {
// the user specified something to deploy, but there isn't anything
Expand Down