Repository navigation
fix: ad-hoc sign the whole macOS app bundle - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS build had a linker signature on the binary only. The app bundle had no valid signature, and
codesign --verify --deep --strictfailed with "code has no resources but signature indicates they must be present".This change sets
bundle.macOS.signingIdentityto"-"intauri.macos.conf.json. The bundler then gives the whole app bundle an ad-hoc signature with the hardened runtime.The app is still not notarized. After a download, macOS still says that the app is damaged until the user removes the quarantine flag. The README tells the user how to do this.
This PR also releases 1.1.1.
Checks
tauri build --target aarch64-apple-darwin --bundles appgivesflags=0x10002(adhoc,runtime), andcodesign --verify --deep --strictpasses.