Repository navigation
fix: close the task view when the scope changes - #1
Merged
Merged
Conversation
The open task belongs to the board that it was opened from. Selecting another view, project, thread or assignee now closes it. Selecting the current scope again keeps it open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting another view, project, thread or assignee closes the open task view. This applies to the sidebar and to the
view.*keyboard shortcuts. Selecting the current scope again keeps the task view open.selectScopeinsrc/state/store.tscallsclose()when the new scope is different from the current scope.sameScopemoved tosrc/board/sidebar.ts, so that the store and the sidebar use the same function.src/components/Shell.test.tsxused a scope change only to get an open task that is not on the board. It now gets that state from a refresh.Tests:
npm test(477 passed) andnpm run typecheck.