Skip to content

Add full-height vertical eighth window actions - #1854

Open
Soren90912 wants to merge 1 commit into
rxhanson:mainfrom
Soren90912:feature/vertical-eighths
Open

Soren90912 wants to merge 1 commit into
rxhanson:mainfrom
Soren90912:feature/vertical-eighths

Conversation

@Soren90912

@Soren90912 Soren90912 commented Sep 13, 2026

Copy link
Copy Markdown

Summary

Adds 8 new full-height vertical eighth window actions for wide and ultrawide displays.

Each action places the window into one of eight equal-width columns across the usable screen area:

  • First Vertical Eighth
  • Second Vertical Eighth
  • Third Vertical Eighth
  • Fourth Vertical Eighth
  • Fifth Vertical Eighth
  • Sixth Vertical Eighth
  • Seventh Vertical Eighth
  • Last Vertical Eighth

The existing 4x2 eighth actions and their identifiers remain unchanged.

Implementation

  • Added 8 new WindowAction cases with stable identifiers.
  • Added a shared VerticalEighthCalculation.
  • Uses the current screen's adjusted visible frame.
  • Handles widths that are not evenly divisible by 8 without cumulative gaps or overlap.
  • Supports Rectangle's existing gap behavior.
  • Added shortcut preference rows and icons.
  • Added English and Traditional Chinese localization.
  • Works across multiple displays.

Screenshots

Shortcut preferences

Shortcut preferences

Vertical eighth placement

Vertical eighth placement

Validation

  • 344 tests passed.
  • Debug build passed.
  • Release build passed.
  • Manual smoke test passed:
    • shortcut configuration
    • first / second vertical eighth placement
    • rightmost eighth boundary
    • gap behavior
    • second display
  • Existing 4x2 eighth behavior remains unchanged.

@rxhanson

Copy link
Copy Markdown
Owner

Thanks for contributing. Typically I would suggest moving these into the Extras button popover in the General tab, but I'm in the middle of converting the shortcuts settings tab into an outline view to accommodate more sizes. Seeing as there's already a merge conflict on this PR, perhaps the best path forward is to hold off on making more changes until the outline view is in place? The alternative would be to simply pull out the Storyboard changes for now and fix the merge conflict and I can add them back into the outline view when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants