fix(controller): index shared tenant references#189
Merged
Conversation
16 tasks
GatewayJ
marked this pull request as ready for review
July 19, 2026 04:50
Member
Author
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
GatewayJ
force-pushed
the
fix/controller-reference-index
branch
from
July 19, 2026 05:53
3e578af to
590c550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
N/A
Summary of Changes
configMapKeyRefentriesInitDonerustfs.tenantlabels on user-owned Secrets and ConfigMaps; routing now comes from Tenant spec references or Tenant owner referencesget,list, andwatch, with a namespaced Role for STS auto TLS Secret creation and fixed-name updateChecklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
Additional Notes
mainafter fix(controller): route shared Secret events to all Tenants #188. This preserves shared Secret event behavior while replacing its per-event Tenant scan and startup Secret label cleanup with the event-driven reverse index.ObjectMeta.createbyresourceNames. The STS Role therefore permits Secret creation only in the Operator namespace, whileget/updateis limited tosts-tls; it grants nopatchordelete.rbac.create=falsemust provide equivalent namespaced permissions whensts.enabled=true,sts.tls.enabled=true, andsts.tls.auto=true.make e2e-live-run; all non-live checks pass.CHANGELOG.md.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.